From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add gst-av package
Date: Sat, 11 Feb 2012 17:15:56 +0100 [thread overview]
Message-ID: <201202111715.56823.arnout@mind.be> (raw)
In-Reply-To: <201202111714.27895.arnout@mind.be>
On Saturday 11 February 2012 17:14:27 Arnout Vandecappelle wrote:
> On Saturday 11 February 2012 16:58:12 Peter Korsgaard wrote:
> > >>>>> "Felipe" == Felipe Contreras <felipe.contreras@gmail.com> writes:
> >
> > Felipe> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > A more detailed commit message would be good. How does this differ from
> > gst-ffmpeg? I see you depend on ffmpeg and not libav (which we currently
> > don't have in BR).
>
> To be honest, I find it redundant to repeat the help text of Config.in in
> the commit message when adding a new package. When you look at the project
> history, you will probably already have looked at the package's files first.
That said, an explanation why it depends on ffmpeg instead of libav would be
good. But then in the mk-file, not in the commit message.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-02-11 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 0:17 [Buildroot] [PATCH] Add gst-av package Felipe Contreras
2012-02-11 15:58 ` Peter Korsgaard
2012-02-11 16:14 ` Arnout Vandecappelle
2012-02-11 16:15 ` Arnout Vandecappelle [this message]
2012-02-11 17:22 ` Felipe Contreras
2012-02-11 17:47 ` Peter Korsgaard
2012-02-11 22:54 ` Felipe Contreras
2012-02-12 7:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202111715.56823.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox