From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
Date: Sat, 11 Feb 2012 17:30:49 +0100 [thread overview]
Message-ID: <201202111730.50135.arnout@mind.be> (raw)
In-Reply-To: <1328830956-11154-1-git-send-email-jwoltz@gmail.com>
On Friday 10 February 2012 00:42:36 J.C. Woltz wrote:
> define USB_MODESWITCH_BUILD_CMDS
> - $(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> + $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
> endef
Don't remove TARGET_MAKE_ENV. The CC= is good, however.
>
> define USB_MODESWITCH_INSTALL_TARGET_CMDS
> - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> - $(INSTALL) -D $(@D)/usb_modeswitch.setup -m 0644 \
> - $(TARGET_DIR)/etc/usb_modeswitch.setup
> + $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> endef
Same here.
> +
Redundant whitespace.
> define USB_MODESWITCH_CLEAN_CMDS
> + $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) clean
> rm -f $(TARGET_DIR)/usr/sbin/usb_modeswitch
> rm -f $(TARGET_DIR)/etc/usb_modeswitch.setup
> rm -f $(TARGET_DIR)/usr/share/man/man1/usb_modeswitch.1
Actually, the rm -f lines should be in UNINSTALL_CMDS. And should use
$(RM) instead of rm -f.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2012-02-11 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 23:42 [Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3 J.C. Woltz
2012-02-10 7:29 ` Thomas De Schampheleire
2012-02-10 14:28 ` J.C. Woltz
2012-02-10 16:41 ` Thomas De Schampheleire
2012-02-11 16:24 ` Arnout Vandecappelle
2012-02-11 16:30 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202111730.50135.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox