Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3-resend 1/2] usb_modeswitch: update to 1.2.3
Date: Sun, 12 Feb 2012 23:21:34 +0100	[thread overview]
Message-ID: <201202122321.34627.arnout@mind.be> (raw)
In-Reply-To: <1329073793-524-1-git-send-email-jwoltz@gmail.com>

On Sunday 12 February 2012 20:09:52 J.C. Woltz wrote:
> This patch updates usb_modeswitch to version 1.2.3.
> The usb_modeswitch.mk needed to be modified for usb_modeswitch to compile.
> Also added extra remove section for the added help scripts and files.
> 
> Signed-off-by: J.C. Woltz <jwoltz@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Thank you for your contribution!

 Still two remarks for the next time you make a patch.

- Comments about the evolution of the patch, that don't need to end up
in the git repository, like the one below, should go under three dashes.
That way Peter can simply run 'git am' on your patch and the unnecessary
comments will not be taken up in the git log.

- .patch files should have a comment at the top explaining why it is needed,
and a Signed-off-by line.  Also, try to send the patch upstream, so we
don't need to carry it forward forever.

 Regards,
 Arnout


> replace TARGET_MAKE_ENV and add USB_MODESWITCH_UNINSTALL_CMDS
> as recommended by Arnout Vandecappelle
> 
> Signed-off-by: J.C. Woltz <jwoltz@gmail.com>
> ---
[snip]

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2012-02-12 22:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-12 19:09 [Buildroot] [PATCH v3-resend 1/2] usb_modeswitch: update to 1.2.3 J.C. Woltz
2012-02-12 19:09 ` [Buildroot] [PATCH v3-resend 2/2] new program: usb_modeswitch_data J.C. Woltz
2012-02-12 22:29   ` Arnout Vandecappelle
2012-02-13  3:00     ` J.C. Woltz
2012-02-13  8:03     ` Thomas De Schampheleire
2012-02-13 16:59       ` J.C. Woltz
2012-02-14 23:46         ` Arnout Vandecappelle
2012-02-14 23:48           ` [Buildroot] [PATCH] tcl: replace option to install library only with positive option to install tclsh Arnout Vandecappelle
2012-02-16  0:09             ` J.C. Woltz
2012-07-15 21:37             ` Thomas Petazzoni
2012-07-25 17:01               ` Arnout Vandecappelle
2012-02-13 21:40       ` [Buildroot] [PATCH v3-resend 2/2] new program: usb_modeswitch_data Arnout Vandecappelle
2012-02-14  9:22         ` Thomas De Schampheleire
2012-02-14 17:30           ` Arnout Vandecappelle
2012-02-12 19:19 ` [Buildroot] [PATCH v3-resend 1/2] usb_modeswitch: update to 1.2.3 J.C. Woltz
2012-02-12 22:21 ` Arnout Vandecappelle [this message]
2012-02-13  2:57   ` J.C. Woltz
2012-02-14  6:47     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202122321.34627.arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox