Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit branch/next] DOWNLOAD_WGET: use -O instead of -P to set output file
Date: Tue, 14 Feb 2012 23:59:40 +0100	[thread overview]
Message-ID: <201202142359.40902.arnout@mind.be> (raw)
In-Reply-To: <CA+appbOf=yN3pWw_HC12BL3sy=SUbMK2CE7pa6MeaQMvLwO6fg@mail.gmail.com>

On Tuesday 14 February 2012 18:54:22 Spenser Gilliland wrote:
> After greping through the source the enormity of that patch and the
> potential for out of tree breakage suggest a different course of
> action.  A possible solution may be to scan the SITE var for a
> question mark and only change to non-slash mode on that occasion.
> Would this be reasonable?

 Yeah, my patch was too easy :-)

 I think it's better to keep the split at the /

 We could use either
microblaze_v2.0.git;a=blob;f=microblaze-unknown-linux-gnu.tgz
or
?p=xldk/microblaze_v2.0.git;a=blob;f=microblaze-unknown-linux-gnu.tgz
as the _SOURCE.  Of course, that still requires some serious massaging
to avoid funky filenames that break everything.  So probably not an
option either.

 I think on the short term it is probably best to use a work-around
like for the blackfin toolchain: a non-standard download target, that
doesn't use the DOWNLOAD function but a custom $(WGET) call.

 On the longer term we could try to refactor that into the generic
DOWNLOAD function.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120214/dc64ecd5/attachment-0001.html>

      parent reply	other threads:[~2012-02-14 22:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 11:07 [Buildroot] [git commit branch/next] DOWNLOAD_WGET: use -O instead of -P to set output file Peter Korsgaard
2012-02-14 15:53 ` Spenser Gilliland
2012-02-14 15:55   ` Alvaro Gamez
2012-02-14 16:01     ` Peter Korsgaard
2012-02-14 16:14       ` Spenser Gilliland
2012-02-14 16:30         ` Peter Korsgaard
2012-02-14 17:54           ` Spenser Gilliland
2012-02-14 22:33             ` Peter Korsgaard
2012-02-14 22:59             ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202142359.40902.arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox