From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 4796] New: apply-patches.sh reorders patches given on the command line
Date: Mon, 27 Feb 2012 13:54:51 +0100 [thread overview]
Message-ID: <20120227125451.GC12248@game.jcrosoft.org> (raw)
In-Reply-To: <20120227082616.GJ23707@ldesroches-Latitude-E6320>
On 09:26 Mon 27 Feb , Ludovic Desroches wrote:
> Hello,
>
> Sorry I don't know if it's the good way to answer on the mailing list
> instead of bugzilla.
>
> Since my goal is to discuss about sorting or not sorting in relation with
> the patch is sent, I choose the mailing list.
>
> > When support/scripts/apply-patches.sh is given an explicit list of patches
> > instead of a template, they are sorted by name before being applied. This is
> > bad as sometimes the order of patches is important, e.g. if one patch depends
> > on another one. This happens e.g. when applying Debian patches whose order is
> > explicitly described in the file debian/patches/series.
> >
> > The culprit is a "ls -d" which has to be changed to "ls -dU" in order to
> > prevent sorting to take place. I have attached a corresponding patch.
>
>
> This patch contradicts the patches I have done to manage archive containing
> several patches in a proper way.
>
> For instance, we have an archive containing patches (from a git branch) whose
> names should be 0001-patch1, 0002-patch2, etc. If we don't use sorting they
> would not be applied in the good order.
>
> I was suspecting that we would have some issues with some kind of patches as
> debian ones.
>
> What should be the good solution? Changing patch naming rules? Managing in a
> specific way some kind of patch? Don't sort a list of patches but sort the
> patches extracted into a directory?
I agree with you maybe the best way is to use a quilt
I use this ofen and it's great it will allow also to have different patch
series depending on the version of the package
convert a git patch series in a quilt is quite easy
Best Regards,
J.
next prev parent reply other threads:[~2012-02-27 12:54 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 20:57 [Buildroot] [Bug 4796] New: apply-patches.sh reorders patches given on the command line bugzilla at busybox.net
2012-02-27 8:26 ` Ludovic Desroches
2012-02-27 12:54 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-02-28 21:19 ` Arnout Vandecappelle
2012-03-08 12:00 ` [Buildroot] [RFC] using series file ludovic.desroches at atmel.com
2012-03-08 12:00 ` [Buildroot] [PATCH] apply-patches.sh: use series file to apply patches in proper order ludovic.desroches at atmel.com
2012-03-08 10:48 ` Samuel Martin
2012-03-08 14:06 ` Ludovic Desroches
2012-03-08 15:50 ` Samuel Martin
2012-03-08 19:11 ` ludovic.desroches at atmel.com
2012-03-08 17:29 ` Samuel Martin
2012-03-12 8:57 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13 10:08 ` Thomas De Schampheleire
2012-03-13 13:19 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13 13:05 ` Julien Boibessot
2012-03-13 21:23 ` Ludovic Desroches
2012-03-14 8:59 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <4F606AF2.2010400@atmel.com>
2012-03-14 10:04 ` Thomas Petazzoni
2012-03-14 10:42 ` Ludovic Desroches
2012-03-14 11:03 ` Thomas Petazzoni
2012-03-14 15:33 ` ludovic.desroches at atmel.com
2012-03-14 15:33 ` [Buildroot] [PATCH 1/6] apply-patches.sh: check if there are rejects before applying patches ludovic.desroches at atmel.com
2012-03-14 21:41 ` Thomas Petazzoni
2012-03-14 22:32 ` Peter Korsgaard
2012-03-15 8:13 ` Ludovic Desroches
2012-03-14 15:33 ` [Buildroot] [PATCH 2/6] apply-patches.sh: rename targetdir to builddir ludovic.desroches at atmel.com
2012-03-14 21:42 ` Thomas Petazzoni
2012-03-20 22:50 ` Peter Korsgaard
2012-03-14 15:33 ` [Buildroot] [PATCH 3/6] apply-patches.sh: cleanup ludovic.desroches at atmel.com
2012-03-14 21:42 ` Thomas Petazzoni
2012-03-20 22:51 ` Peter Korsgaard
2012-03-14 15:33 ` [Buildroot] [PATCH 4/6] apply-patches.sh: directories are no more considered as overlays ludovic.desroches at atmel.com
2012-03-14 21:42 ` Thomas Petazzoni
2012-03-20 22:52 ` Peter Korsgaard
2012-03-14 15:33 ` [Buildroot] [PATCH 5/6] apply-patches.sh: change archive management ludovic.desroches at atmel.com
2012-03-14 21:43 ` Thomas Petazzoni
2012-03-15 8:27 ` Ludovic Desroches
2012-03-20 23:05 ` Peter Korsgaard
2012-03-14 15:33 ` [Buildroot] [PATCH 6/6] apply-patches.sh: use series file to apply patches in proper order ludovic.desroches at atmel.com
2012-03-14 21:43 ` Thomas Petazzoni
2012-03-20 23:07 ` Peter Korsgaard
2012-03-21 8:23 ` Ludovic Desroches
2012-03-21 9:02 ` Peter Korsgaard
2012-03-21 10:05 ` Ludovic Desroches
2012-03-21 13:26 ` ludovic.desroches at atmel.com
2012-03-21 12:26 ` Thomas Petazzoni
2012-03-21 13:02 ` Peter Korsgaard
2012-03-21 13:26 ` [Buildroot] [PATCH] apply-patches.sh: add recursivity when scanning patchdir ludovic.desroches at atmel.com
2012-03-21 12:48 ` Peter Korsgaard
2012-03-21 9:05 ` [Buildroot] [PATCH 6/6] apply-patches.sh: use series file to apply patches in proper order Thomas Petazzoni
2012-03-14 21:51 ` [Buildroot] [PATCH] " Thomas Petazzoni
2012-03-15 8:33 ` Ludovic Desroches
2012-03-15 10:46 ` [Buildroot] [Bug 4796] apply-patches.sh reorders patches given on the command line bugzilla at busybox.net
2012-03-15 10:46 ` bugzilla at busybox.net
2013-05-26 11:58 ` bugzilla at busybox.net
2013-05-26 12:31 ` bugzilla at busybox.net
2013-05-26 12:40 ` bugzilla at busybox.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227125451.GC12248@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox