From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3] qt: Add option to build and install tools on the target
Date: Sun, 4 Mar 2012 21:54:05 +0100 [thread overview]
Message-ID: <201203042154.05630.arnout@mind.be> (raw)
In-Reply-To: <1330887941-29437-1-git-send-email-ismael.luceno@gmail.com>
On Sunday 04 March 2012 20:05:41 Ismael Luceno wrote:
>
> Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
If you make several versions of a patch it's useful to have a changelog
that specifies what you changed compared to the previous version.
> +menuconfig BR2_PACKAGE_QT_TOOLS
> + bool "Compile and install tools"
> + depends on BR2_PACKAGE_QT_SQL_MODULE && BR2_PACKAGE_QT_GUI_MODULE
> + help
> + SQL module is nedded to build, but only required at run-time by a
> + few tools (assistant, designer, qmlviewer).
nedded -> needed
This help text doesn't make much sense here; I meant as part of the
"Tools need the SQL and GUI modules" comment. But actually there it
also doesn't make sense because nobody looks at the help text of a
comment.
So maybe just leave it as a #-comment.
[snip]
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-03-04 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 19:05 [Buildroot] [PATCHv3] qt: Add option to build and install tools on the target Ismael Luceno
2012-03-04 20:54 ` Arnout Vandecappelle [this message]
2012-03-05 9:03 ` [Buildroot] [PATCH] " Ismael Luceno
2012-03-05 9:32 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203042154.05630.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox