From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/1] libgsl : new package The GNU Scientific Library
Date: Mon, 12 Mar 2012 08:02:36 +0100 [thread overview]
Message-ID: <20120312080236.730d91c5@skate> (raw)
In-Reply-To: <1331518764-27555-2-git-send-email-sagaert.johan@skynet.be>
Le Mon, 12 Mar 2012 03:19:24 +0100,
Sagaert Johan <sagaert.johan@skynet.be> a ?crit :
> +LIBGSL_VERSION=1.14
> +LIBGSL_SOURCE=gsl-$(LIBGSL_VERSION).tar.gz
> +LIBGSL_SITE=ftp://ftp.gnu.org/gnu/gsl/
Could you please put spaces before and after = ?
Could you use BR2_GNU_MIRROR ?
> +LIBGSL_INSTALL_STAGING = YES
> +LIBGSL_INSTALL_TARGET = YES
This last line is not needed, it's the default.
> +$(eval $(call AUTOTARGETS,package,libgsl))
This should just be:
$(eval $(call AUTOTARGETS))
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2012-03-12 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 2:19 [Buildroot] [PATCH v1 0/1] New package : GSL The GNU Scientific Library Sagaert Johan
2012-03-12 2:19 ` [Buildroot] [PATCH v1 1/1] libgsl : new package " Sagaert Johan
2012-03-12 7:02 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312080236.730d91c5@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox