From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Downloadsite DHCP changed
Date: Thu, 15 Mar 2012 08:10:46 +0100 [thread overview]
Message-ID: <20120315081046.5e88ba0a@skate> (raw)
In-Reply-To: <1331783706-15520-1-git-send-email-markus.kaindl@stusta.mhn.de>
Hello Markus,
Excellent! You are almost there with your Git patch. You need to fix
two final things:
* The short description of the patch should rather describe what the
patch does rather than the reason why it does. Something like
"dhcp: update HTTP site location" or similar. But that's just a
matter of taste.
* Our commit log must include a Markus Kaindl
<markus.kaindl@stusta.mhn.de> line. So basically, your commit log
should look like:
=====================================================================
dhcp: update HTTP site location
Signed-off-by: Markus Kaindl <markus.kaindl@stusta.mhn.de>
=====================================================================
And then your patch will be perfect.
I am sorry to be annoying about this, but those are the rules we all
follow in the Buildroot community, and I think it is a good idea to
explain them to new contributors.
Thanks for your work and persistence!
Thomas
Le Thu, 15 Mar 2012 04:55:06 +0100,
Markus Kaindl <markus.kaindl@stusta.mhn.de> a ?crit :
> ---
> package/dhcp/dhcp.mk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index 10bdc2e..9ec27d3 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -5,7 +5,7 @@
> #############################################################
>
> DHCP_VERSION = 4.1-ESV-R4
> -DHCP_SITE = http://ftp.isc.org/isc/dhcp
> +DHCP_SITE = http://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
> DHCP_CONF_ENV = ac_cv_file__dev_random=yes
> DHCP_CONF_OPT = \
> --localstatedir=/var/lib/dhcp \
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-03-15 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 3:55 [Buildroot] [PATCH] Downloadsite DHCP changed Markus Kaindl
2012-03-15 7:10 ` Thomas Petazzoni [this message]
2012-03-16 0:29 ` Markus Kaindl
2012-03-15 9:45 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315081046.5e88ba0a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox