Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Config.in.arch: add help and less cryptic names to architecture menu
Date: Mon, 19 Mar 2012 22:23:44 +0100	[thread overview]
Message-ID: <201203192223.45202.arnout@mind.be> (raw)
In-Reply-To: <1332112382-30786-1-git-send-email-alvaro.gamez@hazent.com>

On Monday 19 March 2012 00:13:01 Alvaro G. M wrote:
> From: "Alvaro G. M" <alvaro.gamez@hazent.com>
> 
> 
> Signed-off-by: Alvaro G. M <alvaro.gamez@hazent.com>

 Except for the small issues mentioned below:
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
> This is my penitence for the extra quote on Microblaze. 

 Good work!  Feel free to add extra quotes all over the place if this
is your penitence :-)

> I am not quite
> sure the help texts are good enough, but couldn't think of anything better.

 Good enough for me, for sure.  The links to wikipedia are really a 
good idea.

> ---
>  target/Config.in.arch |   95 ++++++++++++++++++++++++++++++++++++++++++------
>  1 files changed, 83 insertions(+), 12 deletions(-)
> 
> diff --git a/target/Config.in.arch b/target/Config.in.arch
> index 17e0236..860a85a 100644
> --- a/target/Config.in.arch
> +++ b/target/Config.in.arch
> @@ -8,40 +8,111 @@ choice
>           Select the target architecture family to build for.
>  
>  config BR2_arm
> -       bool "arm"
> +       bool "ARM (little endian)"
> +       help
> +         ARM is a 32-bit reduced instruction set computer (RISC) instruction
> +          set architecture (ISA) developed by ARM Holdings. Little endian.

 Whitespace error: spaces instead of tab.

> +         http://www.arm.com/
> +         http://en.wikipedia.org/wiki/ARM
>  config BR2_armeb

 There should be an empty line between the help text and the next 
config, otherwise it doesn't look good in xconfig.

> -       bool "armeb"
> +       bool "ARM (big endian)"
> +       help
> +         ARM is a 32-bit reduced instruction set computer (RISC) instruction
> +          set architecture (ISA) developed by ARM Holdings. Big endian.

 Whitespace error: spaces instead of tab.

> +         http://www.arm.com/
> +         http://en.wikipedia.org/wiki/ARM

[snip]

 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120319/874f79b7/attachment-0001.html>

  reply	other threads:[~2012-03-19 21:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-18 23:13 [Buildroot] [PATCH] Config.in.arch: add help and less cryptic names to architecture menu Alvaro G. M
2012-03-19 21:23 ` Arnout Vandecappelle [this message]
2012-03-19 21:56 ` Alvaro G. M
2012-03-19 22:36   ` Arnout Vandecappelle
2012-03-20 13:15   ` Thomas Petazzoni
2012-03-20 13:17     ` Alvaro Gamez
2012-03-20 13:30   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203192223.45202.arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox