From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Tue, 20 Mar 2012 00:45:18 +0100 Subject: [Buildroot] [PATCH 4/6] Rework of the init system In-Reply-To: References: Message-ID: <201203200045.18897.arnout@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Monday 19 March 2012 16:59:38 Maxime Ripard wrote: > +choice > + prompt "Init system" > + default BR2_INIT_BUSYBOX > + help > + To select systemd, you first need to have dbus and udev enabled Only udev. Anyway, the help text of a choice is never shown, so this won't work. I don't know if it's possible to add comments in a choice, but that would be the way to go. > + > +config BR2_INIT_BUSYBOX > + bool "Busybox init" > + select BR2_PACKAGE_BUSYBOX > + > +config BR2_INIT_SYSV > + bool "Use systemV init" > + select BR2_PACKAGE_SYSVINIT > + > +config BR2_INIT_SYSTEMD > + bool "Use systemd" > + select BR2_PACKAGE_DBUS > + depends on BR2_PACKAGE_UDEV Would it be an option to make this a select BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV instead? (With a depends on LARGEFILE and WCHAR, of course.) Or is that a bad idea? > + select BR2_PACKAGE_SYSTEMD The latter two selects are only possible if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS is selected. The select/depends combination breaks the dependency of BR2_PACKAGE_SYSVINIT and BR2_PACKAGE_SYSTEMD on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS. So the systemd package will be selected, but it's not visible to the user. Of course, there's nothing strictly wrong with that. It's just a bit strange. Clearly, adding a select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS here is a bad idea. I also don't like much to add a dependency on it either. So instead, I propose to move sysvinit and systemd out of the BR2_PACKAGE_BUSYBOX_SHOW_OTHERS condition (in package/Config.in). They anyway can't be selected or deselected by the user, since their selection is fully determined by the BR2_INIT_* option. > + > +endchoice -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F