From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] ushare: new package
Date: Wed, 21 Mar 2012 14:21:02 +0100 [thread overview]
Message-ID: <20120321142102.5c5999a6@skate> (raw)
In-Reply-To: <1332335538-23508-1-git-send-email-gustavo@zacarias.com.ar>
Le Wed, 21 Mar 2012 10:12:18 -0300,
Gustavo Zacarias <gustavo@zacarias.com.ar> a ?crit :
> --- /dev/null
> +++ b/package/ushare/ushare.mk
> @@ -0,0 +1,26 @@
> +#############################################################
> +#
> +# ushare
> +#
> +#############################################################
> +
> +USHARE_VERSION = 1.1a
> +USHARE_SOURCE = ushare-$(USHARE_VERSION).tar.bz2
> +USHARE_SITE = http://ushare.geexbox.org/releases
> +USHARE_DEPENDENCIES = host-pkg-config libupnp
> +
> +define USHARE_CONFIGURE_CMDS
> + (cd $(@D); \
> + $(TARGET_CONFIGURE_OPTS) \
> + ./configure --prefix=/usr $(DISABLE_NLS) --cross-compile \
> + --cross-prefix="$(TARGET_CROSS)" --sysconfdir=/etc \
> + --disable-strip --disable-debug \
> + )
> +endef
> +
> +define USHARE_INSTALL_TARGET_CMDS
> + $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> + rm -f $(TARGET_DIR)/etc/init.d/ushare
> +endef
> +
> +$(eval $(call GENTARGETS))
With GENTARGETS, xxx_BUILD_CMDS is empty by default. Are you sure this
builds?
Also, can you add a comment just before USHARE_CONFIGURE_CMDS saying
that despite the appearance, autotools are not used. However, I am sure
in the future many people will wonder why AUTOTARGETS was not used.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-03-21 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 13:12 [Buildroot] [PATCH v2] ushare: new package Gustavo Zacarias
2012-03-21 13:21 ` Thomas Petazzoni [this message]
2012-03-21 13:39 ` Gustavo Zacarias
2012-03-21 13:44 ` Thomas Petazzoni
2012-03-21 14:15 ` Gustavo Zacarias
2012-03-21 22:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321142102.5c5999a6@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox