From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add lcdproc config options, for driver selection
Date: Wed, 11 Apr 2012 12:17:41 +0200 [thread overview]
Message-ID: <20120411121741.173594a3@skate> (raw)
In-Reply-To: <1334138568-28717-1-git-send-email-spdawson@gmail.com>
Hello Simon,
Le Wed, 11 Apr 2012 11:02:48 +0100,
spdawson at gmail.com a ?crit :
> From: Simon Dawson <spdawson@gmail.com>
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
> package/lcdproc/Config.in | 246 ++++++++++++++++++++++++++++++++++++++++++++
> package/lcdproc/lcdproc.mk | 151 +++++++++++++++++++++++++++-
> 2 files changed, 396 insertions(+), 1 deletions(-)
Thanks for this patch. I am wondering whether we should have such a
long list of drivers as a menu, or whether we should just provide an
option to give a comma-separated list of drivers. Something like the
following choice:
[ ] Build all drivers
[ ] Build custom list of drivers
When the second choice is enabled, then it shows:
() List of drivers to build
But I don't feel really strongly about this, so please wait for
comments from other Buildroot developers before working on such change.
> +LCDPROC_CONF_OPT = --enable-drivers=$(shell echo $(LCDPROC_DRIVERS) | sed -e 's/ /,/g')
This can be done in pure make:
LCDPROC_CONF_OPT = --enable-drivers=$(subst $(space),$(comma),$(LCDPROC_DRIVERS))
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-04-11 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 10:02 [Buildroot] [PATCH] Add lcdproc config options, for driver selection spdawson at gmail.com
2012-04-11 9:53 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-11 10:17 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-11 11:07 spdawson at gmail.com
2012-04-11 11:31 spdawson at gmail.com
2012-04-11 11:40 ` Thomas Petazzoni
2012-04-11 12:12 spdawson at gmail.com
2012-05-01 20:33 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411121741.173594a3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox