Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package read-edid, corrected patch
Date: Fri, 4 May 2012 06:29:34 +0300	[thread overview]
Message-ID: <20120504032933.GC2763@tarshish> (raw)
In-Reply-To: <CADiAo4KA0+q00pCFAXuebB9WtFkJ8WcfkerB0Sv57rtPTnu2RQ@mail.gmail.com>

Hi Dimitry,

On Thu, May 03, 2012 at 10:14:53PM -0400, Dimitry Golubovsky wrote:
> Hi,
> Here is the updated patch per comments by Thomas and Baruch.
> 
> Thanks.

The text here should contain the patch changelog information. This goes 
directly to the git log. Other free text goes below...

> Signed-off-by: Dmitry Golubovsky <golubovsky@gmail.com>
> ---

here.

> diff --git a/package/Config.in b/package/Config.in
> index caa618b..e39fccf 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -210,6 +210,7 @@ source "package/openocd/Config.in"
>  source "package/parted/Config.in"
>  source "package/pciutils/Config.in"
>  source "package/picocom/Config.in"
> +source "package/read-edid/Config.in"
>  source "package/rng-tools/Config.in"
>  source "package/sane-backends/Config.in"
>  source "package/sdparm/Config.in"
> diff --git a/package/read-edid/Config.in b/package/read-edid/Config.in
> new file mode 100644
> index 0000000..c66a5e0
> --- /dev/null
> +++ b/package/read-edid/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_READ_EDID
> +	bool "read-edid"
> +	help
> +	  Read-edid is a pair of tools (originally by John Fremlin) for
> reading the EDID
> +	  from a monitor.  It should work with most monitors made since 1996
> (except for
> +	  newer ones with 256-byte EDID's - WiP),  assuming the video card
> supports  the
> +	  standard read commands (most do).  Read-edid is a set of two tools
> - get-edid,
> +	  which gets  the raw edid  information from the monitor,  and
> parse-edid, which
> +	  turns the raw binary information into an XF86Config-compatible
> monitor section.

Your patch is line wrapped. I still suggest you to consider 'git send-email'.

> +
> +	  http://polypux.org/projects/read-edid/
> +
> +depends on (BR2_i386)

This line should be placed just below the 'bool "read-edid"' line, and be tab 
indented. The help text should be indented with tab + 2 spaces.

> +
> +
> diff --git a/package/read-edid/read-edid.mk b/package/read-edid/read-edid.mk
> new file mode 100644
> index 0000000..6328def
> --- /dev/null
> +++ b/package/read-edid/read-edid.mk
> @@ -0,0 +1,20 @@
> +############################################
> +#
> +# read-edid
> +#
> +############################################
> +
> +READ_EDID_VERSION = 1.4.2
> +READ_EDID_SITE = http://www.polypux.org/projects/read-edid/
> +
> +define READ_EDID_BUILD_CMDS
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
> +endef
> +
> +define READ_EDID_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/get-edid $(TARGET_DIR)/sbin/get-edid
> +	$(INSTALL) -D -m 0755 $(@D)/parse-edid $(TARGET_DIR)/sbin/parse-edid
> +endef
> +
> +$(eval $(call AUTOTARGETS))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2012-05-04  3:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04  2:14 [Buildroot] [PATCH] package read-edid, corrected patch Dimitry Golubovsky
2012-05-04  3:29 ` Baruch Siach [this message]
2012-05-04  8:02   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120504032933.GC2763@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox