Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Adjust v86d.mk per better source URL and build method.
Date: Mon, 7 May 2012 14:00:13 +0300	[thread overview]
Message-ID: <20120507110012.GB8916@sapphire.tkos.co.il> (raw)
In-Reply-To: <1336386538-27684-2-git-send-email-golubovsky@gmail.com>

Hi Dmitry,

Please squash this patch into the previous one, and send a single fixed patch.

A couple more comments below.

On Mon, May 07, 2012 at 06:28:58AM -0400, Dmitry wrote:
>  * git source URL -> http source URL
>  * AUTOTARGETS -> GENTARGETS
> 
> Signed-off-by: Dmitry <golubovsky@gmail.com>
> ---
>  package/v86d/v86d.mk |   23 +++++++++++------------
>  1 files changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/package/v86d/v86d.mk b/package/v86d/v86d.mk
> index 035797e..5147a2d 100644
> --- a/package/v86d/v86d.mk
> +++ b/package/v86d/v86d.mk
> @@ -4,23 +4,22 @@
>  # 
>  ############################################
>  
> -V86D_VERSION = v86d-0.1.10
> -V86D_SITE = git://repo.or.cz/v86d.git
> -
> -# It is necessary to define __i386__ explicitly for successful compilation.
> -
> -define V86D_BUILD_CMDS
> -	$(MAKE) CC="$(TARGET_CC) -D__i386__" LD="$(TARGET_LD)" -C $(@D) all
> -endef
> -
> -V86D_POST_CONFIGURE_HOOKS += V86D_REALLY_RUN_CONFIGURE
> +V86D_VERSION = 0.1.10
> +V86D_SOURCE = v86d-$(V86D_VERSION).tar.bz2
> +V86D_SITE = http://dev.gentoo.org/~spock/projects/uvesafb/archive
>  
>  # v86d's configure script is not autoconf-based: parameters
>  # supplied by Buildroot cause it to produce no result; explicit
>  # invocation is needed.

Since you don't use Buildroot's autoconf support, this comment is no longer 
relevant.

>  
> -define V86D_REALLY_RUN_CONFIGURE
> +define V86D_CONFIGURE_CMDS
>  	(cd $(@D) ; ./configure --default)
>  endef
>  
> -$(eval $(call AUTOTARGETS))
> +# It is necessary to define __i386__ explicitly for successful compilation.
> +
> +define V86D_BUILD_CMDS
> +	$(MAKE) CC="$(TARGET_CC) -D__i386__" LD="$(TARGET_LD)" -C $(@D) all

You can used $(TARGET_CONFIGURE_OPTS) here as well.

baruch

> +endef
> +
> +$(eval $(call GENTARGETS))

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2012-05-07 11:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07 10:28 [Buildroot] [PATCH 1/2] Added package v86d which provides a real-mode helper for uvesafb driver Dmitry
2012-05-07 10:28 ` [Buildroot] [PATCH 2/2] Adjust v86d.mk per better source URL and build method Dmitry
2012-05-07 11:00   ` Baruch Siach [this message]
2012-05-07 12:47     ` Dimitry Golubovsky
2012-05-07 12:59       ` Baruch Siach
2012-05-07 13:45       ` Thomas Petazzoni
2012-05-07 13:47         ` Dimitry Golubovsky
2012-05-07 13:55         ` Baruch Siach
2012-05-07 14:04           ` Thomas Petazzoni
2012-05-08  5:15             ` Baruch Siach
2012-05-08  3:39         ` Dmitry Golubovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120507110012.GB8916@sapphire.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox