Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-infra: remove the call from XXXTARGETS
Date: Mon, 14 May 2012 09:58:46 +0200	[thread overview]
Message-ID: <20120514095846.7d206d16@skate> (raw)
In-Reply-To: <1336857045-10679-1-git-send-email-arnout@mind.be>

Le Sat, 12 May 2012 23:10:44 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :

> Replace $(call XXXTARGETS,host) with $(XXXTARGETS_HOST) and
> $(call XXXTARGETS) with $(XXXTARGETS).
> 
> Also includes documentation update, but not for buildroot.html.
> 
> This brings the time for 'make -qp' (which is used by bash-completion)
> down from 1.85s to 1.35s on my laptop.

I haven't tested yet, but I'm fine with the principle. I am just
wondering whether HOST_AUTOTARGETS wouldn't be better than
AUTOTARGETS_HOST for the name of the macro. Or maybe, since we're
renaming everything in this patch it's time to think about a better
name for these macros

 GENPACKAGE / HOST_GENPACKAGE
 GENPKG / HOST_GENPKG
 genpackage / host-genpackage
 genpkg / host-genpkg

 autotoolspackage / host-autotoolspackage
 autotoolspkg / host-autotoolspkg
 cmakepkg / host-cmakepkg
 autotools-package / host-autotools-package
 generic-package / host-generic-package
 autotools-pkg / host-autotools-pkg

Or maybe *TARGETS is just fine, as we have today.

Thoughts?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2012-05-14  7:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-12 21:10 [Buildroot] [PATCH] pkg-infra: remove the call from XXXTARGETS Arnout Vandecappelle
2012-05-14  7:50 ` [Buildroot] [PATCH] Remove redundant $(call...) from pkgname and pkgparentdir Arnout Vandecappelle
2012-05-14  7:58 ` Thomas Petazzoni [this message]
2012-05-14  8:32   ` [Buildroot] [PATCH] pkg-infra: remove the call from XXXTARGETS Arnout Vandecappelle
2012-05-14  9:58     ` Thomas Petazzoni
2012-05-15 18:53       ` Thomas De Schampheleire
2012-06-07 14:16 ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514095846.7d206d16@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox