Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Buildroot and linux-pam?
Date: Wed, 16 May 2012 13:52:53 +0200	[thread overview]
Message-ID: <20120516135253.48a500b3@skate> (raw)
In-Reply-To: <CADiAo4+Co31-t+z_Ydraw_LW5Fwup3TtSJ+GQqYdqQSEtWpOzQ@mail.gmail.com>

Hello Dmitry,

Le Wed, 16 May 2012 06:32:14 -0400,
Dmitry Golubovsky <golubovsky@gmail.com> a ?crit :

> It looks like linux-pam was never included in Buildroot, and there are
> few packages* where use of pam was explicitly disabled.
> 
> I managed to compile it with Buildroot though [1] with a number of
> hacks and workarounds. I tested it (at least pam_exec) with Qingy as a
> login program.
> 
> If I provide a better quality patch, will linux-pam be accepted? If
> yes, will there be any objections to (conditionally) enabling pam at
> least in systemd?

There will at least be no objection on my side, and in general, people
are fine with adding new features to existing packages.

> I am interested in both for my buildroot-based project which needs an
> authrntication facility. If for some reason linux-pam cannot be
> accepted, I'll keep this stuff as part of my project outside the
> buildroot tree.
> 
> Please let me know your opinion, or any suggestions how to improve the
> Makefile (apart from obvious cleanups).

We would definitely welcome libpam as a package. Your hacks don't look
really big, and there are probably ways to make them look a bit nicer.
You're apparently modifying the config.h manually, which is generated
by ./configure script. Isn't it possible by passing environment
variables to the ./configure script, to ensure that the problematic
test gets the appropriate value?

If you give a little bit more details on which problems those hacks are
solving, I'm sure we can help you to come up with solutions.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-05-16 11:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16 10:32 [Buildroot] Buildroot and linux-pam? Dmitry Golubovsky
2012-05-16 11:52 ` Thomas Petazzoni [this message]
2012-05-16 12:55 ` Dmitry Golubovsky
2012-05-23 14:33   ` Shawn Ferris
2012-05-23 14:58     ` Shawn Ferris
  -- strict thread matches above, loose matches on Subject: below --
2012-05-23 19:30 D M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120516135253.48a500b3@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox