From: Julian Lunz <git@jlunz.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] freerdp: new package Signed-off-by: Julian Lunz <git@jlunz.de>
Date: Tue, 5 Jun 2012 23:25:05 +0200 [thread overview]
Message-ID: <20120605232505.25317a1e@jl-desk-LL> (raw)
In-Reply-To: <20120605222402.5bb8b156@skate>
On Tue, 5 Jun 2012 22:24:02 +0200
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> Le Mon, 4 Jun 2012 17:57:40 +0200,
> Julian Lunz <git@jlunz.de> a ?crit :
>
> > ---
> > package/Config.in | 1 +
> > package/freerdp/Config.in | 13 +++++++++++++
> > package/freerdp/freerdp.mk | 41
> > +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55
> > insertions(+), 0 deletions(-)
>
> Thanks, it looks much better. One additional issue: you must put your
> Signed-off-by line after one blank line after the commit title, i.e:
>
> """
> freerdp: new package
>
> Signed-off-by: ....
> """
>
> Otherwise, git believes that your Signed-off-by is part of the commit
> title, which is not nice.
>
> Thomas
Hi,
sorry, now fixed:
[PATCH v2] freerdp: new package
Date: Tue, 5 Jun 2012 23:19:53 +0200
Regards,
Julian
prev parent reply other threads:[~2012-06-05 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 15:57 [Buildroot] [PATCH] freerdp: new package Signed-off-by: Julian Lunz <git@jlunz.de> Julian Lunz
2012-06-05 20:24 ` Thomas Petazzoni
2012-06-05 21:25 ` Julian Lunz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605232505.25317a1e@jl-desk-LL \
--to=git@jlunz.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox