From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 6] pkg-download.mk: allow using localfiles outside of package infrastructure
Date: Wed, 6 Jun 2012 22:14:35 +0200 [thread overview]
Message-ID: <20120606221435.3d843ddd@skate> (raw)
In-Reply-To: <5103c7c0451ff036f611.1338924132@beantl019720>
Le Tue, 05 Jun 2012 21:22:12 +0200,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :
> The localfiles download method uses $($(PKG)_SITE))) and
> $($(PKG)_SOURCE) instead of $(1) and $(2). This means that it can only
> be used for package downloads (through gentargets, autotargets, ...)
> and not for other downloads like external toolchains.
>
> This patch changes localfiles to allow this, just as the wget and scp
> download methods already did.
> For the version control download methods, nothing changes.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
I generally agree with this, but for consistency sake, it should
probably done similarly for all other download methods, no? Of course,
it can be done later as separate patches, the code is already
inconsistent, so this patch does not make it worse from that
perspective.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-06-06 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 19:22 [Buildroot] [PATCH 0 of 6] Improve support for custom external toolchains (and related changes) Thomas De Schampheleire
2012-06-05 19:22 ` [Buildroot] [PATCH 1 of 6] pkg-download.mk: allow using localfiles outside of package infrastructure Thomas De Schampheleire
2012-06-06 20:14 ` Thomas Petazzoni [this message]
2012-06-06 20:18 ` Thomas De Schampheleire
2012-06-05 19:22 ` [Buildroot] [PATCH 2 of 6] pkg-download.mk: use stripurischeme function in localfiles download method Thomas De Schampheleire
2012-06-05 19:22 ` [Buildroot] [PATCH 3 of 6] pkg-download.mk: support detection of URI schemes in DOWNLOAD Thomas De Schampheleire
2012-06-05 19:22 ` [Buildroot] [PATCH 4 of 6] toolchain-external/Config.in: fix indentation Thomas De Schampheleire
2012-06-05 19:22 ` [Buildroot] [PATCH 5 of 6] toolchain-external: allow downloading a custom toolchain Thomas De Schampheleire
2012-06-05 19:22 ` [Buildroot] [PATCH 6 of 6] toolchain-external: line up comments with reality Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606221435.3d843ddd@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox