Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libmad: Add optimization config options
Date: Fri, 13 Jul 2012 21:41:47 +0200	[thread overview]
Message-ID: <20120713214147.7fd4d1e8@skate> (raw)
In-Reply-To: <1218634753.1336082.1342200312454.JavaMail.root@advansee.com>

Hello,

Le Fri, 13 Jul 2012 19:25:12 +0200 (CEST),
Beno?t Th?baudeau <benoit.thebaudeau@advansee.com> a ?crit :

> Changes for v2:
>    - Factorize the 'able' in the $(if ).

I prefer the solution in v1 with regard to this, as it is much easier
to read.

> +choice
> +	prompt "Speed vs. accuracy"
> +	default BR2_PACKAGE_LIBMAD_SPEED_ACCURACY

What about calling those options:

 BR2_PACKAGE_LIBMAD_OPTIMIZATION_SPEED
 BR2_PACKAGE_LIBMAD_OPTIMIZATION_ACCURACY
 BR2_PACKAGE_LIBMAD_OPTIMIZATION_DEFAULT

> +config BR2_PACKAGE_LIBMAD_SPEED_ACCURACY
> +	bool "Optimize for both speed and accuracy"

This should rather be:

	bool "Default"

or something like that. Technically, this option does not enable any
special optimization for both speed and accuracy, it just uses the
default options.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-07-13 19:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <702722447.1326180.1342189637611.JavaMail.root@advansee.com>
2012-07-13 14:28 ` [Buildroot] [PATCH] libmad: Add optimization config options Benoît Thébaudeau
2012-07-13 17:25   ` [Buildroot] [PATCH v2] " Benoît Thébaudeau
2012-07-13 19:41     ` Thomas Petazzoni [this message]
2012-07-13 19:51       ` Benoît Thébaudeau
2012-07-13 20:14         ` [Buildroot] [PATCH v3] " Benoît Thébaudeau
2012-07-13 20:48           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120713214147.7fd4d1e8@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox