From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 1/2] usb_modeswitch: update to 1.2.3
Date: Sun, 15 Jul 2012 23:12:23 +0200 [thread overview]
Message-ID: <20120715231223.5a77873f@skate> (raw)
In-Reply-To: <1332034235-17423-2-git-send-email-jwoltz@gmail.com>
Hello,
[ Reviving an old thread... ]
Le Sat, 17 Mar 2012 21:30:34 -0400,
"J.C. Woltz" <jwoltz@gmail.com> a ?crit :
> This patch updates usb_modeswitch to version 1.2.3.
> The usb_modeswitch.mk needed to be modified for usb_modeswitch to compile.
> Also added extra remove section for the added help scripts and files.
>
> Signed-off-by: J.C. Woltz <jwoltz@gmail.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> replace TARGET_MAKE_ENV and add USB_MODESWITCH_UNINSTALL_CMDS
> as recommended by Arnout Vandecappelle
Why do you use TARGET_MAKE_ENV here? It seems much better to use
TARGET_CONFIGURE_OPTS as you were doing in previous versions of your
patch. Arnout, can you explain why you suggested using TARGET_MAKE_ENV
instead of TARGET_CONFIGURE_OPTS?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-15 21:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 1:30 [Buildroot] [PATCH v5 0/2] usb_modeswitch update and add data J.C. Woltz
2012-03-18 1:30 ` [Buildroot] [PATCH v5 1/2] usb_modeswitch: update to 1.2.3 J.C. Woltz
2012-07-15 21:12 ` Thomas Petazzoni [this message]
2012-07-21 18:01 ` J.C. Woltz
2012-07-24 22:20 ` Arnout Vandecappelle
2012-03-18 1:30 ` [Buildroot] [PATCH v5 2/2] new program: usb_modeswitch_data J.C. Woltz
2012-08-10 10:55 ` Yegor Yefremov
2012-08-12 17:27 ` [Buildroot] [PATCH v5 0/2] usb_modeswitch update and add data Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2012-02-19 17:49 J.C. Woltz
2012-02-19 17:49 ` [Buildroot] [PATCH v5 1/2] usb_modeswitch: update to 1.2.3 J.C. Woltz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120715231223.5a77873f@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox