From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] Add some support for device tree kernels with appended trees
Date: Mon, 16 Jul 2012 14:46:16 +0200 [thread overview]
Message-ID: <20120716144616.675e4f3b@skate> (raw)
In-Reply-To: <1341309676-18681-1-git-send-email-maxime.ripard@free-electrons.com>
Le Tue, 3 Jul 2012 12:01:12 +0200,
Maxime Ripard <maxime.ripard@free-electrons.com> a ?crit :
> This is a refactoring of the previous basic device tree
> options available for microblaze.
>
> The previous option only made it possible for microblaze targets
> to give a path to an external device tree, and build a simpleImage
> with it. This involved using a custom target name as simpleImages
> are built with the simpleImage.dt_name.
> This is also the case on powerpc with cuImages.
>
> This patchset replaces the existing mechanism with a more generic one.
> First, it allows to build device tree sources to blobs, both taking
> dts present in the kernel sources and external ones, using a path.
>
> Then, it adds support for kernel images with appended device tree blobs.
> This option is only for ARM because it is the only architecture I can
> think of that has such feature.
>
> Finally, it adds the simpleImage and cuImage as regular image variants,
> with the necessary logic to append the device tree name to use, while
> doing a bit of code factorisation for u-boot images along the way.
Thanks, I globally like this and find this much better than the
microblaze specific handling we had before. However, could you migrate
this nice cover letter description into the appropriate commit logs?
Your commit logs are really short and do not describe what the commit
is doing, but the commit logs is what is staying in the project
history, so this is where all the attention should be put, rather than
to the cover letter.
I'll reply to the individual patches for details.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2012-07-16 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 10:01 [Buildroot] [PATCHv2] Add some support for device tree kernels with appended trees Maxime Ripard
2012-07-03 10:01 ` [Buildroot] [PATCH 1/4] Rework support for the device tree Maxime Ripard
2012-07-15 12:34 ` Arnout Vandecappelle
2012-07-15 12:41 ` Arnout Vandecappelle
2012-07-16 12:57 ` Thomas Petazzoni
[not found] ` <5006E601.4080807@essensium.com>
2012-07-19 7:42 ` Thomas Petazzoni
2012-07-03 10:01 ` [Buildroot] [PATCH 2/4] Add support for appended device tree blobs for arm Maxime Ripard
2012-07-15 12:41 ` Arnout Vandecappelle
2012-07-16 13:01 ` Thomas Petazzoni
2012-07-16 13:10 ` Thomas Petazzoni
2012-07-03 10:01 ` [Buildroot] [PATCH 3/4] Factorise the u-boot images code Maxime Ripard
2012-07-15 12:42 ` Arnout Vandecappelle
2012-07-16 13:03 ` Thomas Petazzoni
2012-07-03 10:01 ` [Buildroot] [PATCH 4/4] Add cuImage(powerpc) and simpleImage(microblaze) as Linux kernel images variants Maxime Ripard
2012-07-15 12:43 ` Arnout Vandecappelle
2012-07-16 12:46 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716144616.675e4f3b@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox