From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] avahi: only install default.script/S05avahi-setup.sh if not present in fs skeleton
Date: Fri, 20 Jul 2012 11:10:58 +0200 [thread overview]
Message-ID: <20120720111058.7d61e9cf@skate> (raw)
In-Reply-To: <87r4s6u7wq.fsf@macbook.be.48ers.dk>
Hello Peter,
Le Fri, 20 Jul 2012 10:57:25 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :
> Thomas> Well, I think the whole idea of testing whether a
> Thomas> configuration file has already been copied or not to the
> Thomas> target filesystem to avoid overwriting files from the
> Thomas> skeleton is not nice (I think using the post-build script to
> Thomas> overwrite configuration files is a much better idea), but I
> Thomas> know Peter wants this to work.
>
> I don't really feel that strongly about it.
Ok, but either we support it, and we support it completely, or we don't
support it and we remove all those conditional file installations (by
making them unconditional).
> Thomas> The parts around avahi-autoipd are obviously here for a
> Thomas> reason, but why does it need to test for ip= and nfsroot= in
> Thomas> the kernel command line in Avahi case and not in Busybox
> Thomas> case?
>
> Thomas> One possibility would be to simply put the Avahi variant of
> Thomas> the script into the Busybox package. When Avahi is not
> Thomas> installed, the avahi-autoipd tests would simply ensure that
> Thomas> the script does not try to use Avahi.
>
> That was my thought exactly. I had a quick look at it just before I
> got ill, but then forgot about it.
Ok, thanks for your input!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-20 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 4:14 [Buildroot] [PATCH] avahi: only install default.script/S05avahi-setup.sh if not present in fs skeleton Danomi Manchego
2012-07-14 21:43 ` Arnout Vandecappelle
2012-07-17 21:45 ` Thomas Petazzoni
2012-07-20 1:53 ` Danomi Manchego
2012-07-20 8:02 ` Thomas Petazzoni
2012-07-20 8:57 ` Peter Korsgaard
2012-07-20 9:10 ` Thomas Petazzoni [this message]
2012-07-21 2:55 ` Danomi Manchego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720111058.7d61e9cf@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox