From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Clarify MIPS ABIs support
Date: Thu, 26 Jul 2012 21:01:02 +0200 [thread overview]
Message-ID: <20120726210102.6f65719c@skate> (raw)
In-Reply-To: <20120725211514.1ee35d6a@skate>
Le Wed, 25 Jul 2012 21:15:14 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :
> In other words, something like:
>
> From d8b0cd864463dedb8a934d1b2181d1ce074f525f Mon Sep 17 00:00:00 2001
> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Date: Wed, 25 Jul 2012 21:12:59 +0200
> Subject: [PATCH] Simplify x86 target architecture variant handling
>
> Instead of having two separate list of choices for select the target
> architecture variant for i386 and x86_64, with many CPU choices
> duplicated (because all modern x86 CPUs can be both used as i386 or
> x86_64), merge them into a single list. In the x86_64 case, all the
> x86 CPUs that do not support the 64 bits instruction set are hidden.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
What do you think of this proposal (see below).
Thanks!
Thomas
> ---
> target/Config.in.arch | 111 ++++++++++++++---------------------------------
> toolchain/gcc/Config.in | 4 +-
> 2 files changed, 35 insertions(+), 80 deletions(-)
>
> diff --git a/target/Config.in.arch b/target/Config.in.arch
> index 75c5499..34a12bc 100644
> --- a/target/Config.in.arch
> +++ b/target/Config.in.arch
> @@ -337,44 +337,58 @@ config BR2_X86_CPU_HAS_SSSE3
>
> choice
> prompt "Target Architecture Variant"
> - depends on BR2_i386
> - default BR2_x86_i586
> + depends on BR2_i386 || BR2_x86_64
> + default BR2_x86_i586 if BR2_i386
> + default BR2_x86_generic if BR2_x86_64
> help
> Specific CPU variant to use
>
> +config BR2_x86_generic
> + bool "generic"
> config BR2_x86_i386
> bool "i386"
> + depends on !BR2_x86_64
> config BR2_x86_i486
> bool "i486"
> + depends on !BR2_x86_64
> config BR2_x86_i586
> bool "i586"
> + depends on !BR2_x86_64
> config BR2_x86_i686
> bool "i686"
> + depends on !BR2_x86_64
> config BR2_x86_pentiumpro
> bool "pentium pro"
> + depends on !BR2_x86_64
> config BR2_x86_pentium_mmx
> bool "pentium MMX"
> select BR2_X86_CPU_HAS_MMX
> + depends on !BR2_x86_64
> config BR2_x86_pentium_m
> bool "pentium mobile"
> + depends on !BR2_x86_64
> config BR2_x86_pentium2
> bool "pentium2"
> select BR2_X86_CPU_HAS_MMX
> + depends on !BR2_x86_64
> config BR2_x86_pentium3
> bool "pentium3"
> select BR2_X86_CPU_HAS_MMX
> select BR2_X86_CPU_HAS_SSE
> + depends on !BR2_x86_64
> config BR2_x86_pentium4
> bool "pentium4"
> select BR2_X86_CPU_HAS_MMX
> select BR2_X86_CPU_HAS_SSE
> select BR2_X86_CPU_HAS_SSE2
> + depends on !BR2_x86_64
> config BR2_x86_prescott
> bool "prescott"
> select BR2_X86_CPU_HAS_MMX
> select BR2_X86_CPU_HAS_SSE
> select BR2_X86_CPU_HAS_SSE2
> select BR2_X86_CPU_HAS_SSE3
> + depends on !BR2_x86_64
> config BR2_x86_nocona
> bool "nocona"
> select BR2_X86_CPU_HAS_MMX
> @@ -398,16 +412,20 @@ config BR2_x86_atom
> config BR2_x86_k6
> bool "k6"
> select BR2_X86_CPU_HAS_MMX
> + depends on !BR2_x86_64
> config BR2_x86_k6_2
> bool "k6-2"
> select BR2_X86_CPU_HAS_MMX
> + depends on !BR2_x86_64
> config BR2_x86_athlon
> bool "athlon"
> select BR2_X86_CPU_HAS_MMX
> + depends on !BR2_x86_64
> config BR2_x86_athlon_4
> bool "athlon-4"
> select BR2_X86_CPU_HAS_MMX
> select BR2_X86_CPU_HAS_SSE
> + depends on !BR2_x86_64
> config BR2_x86_opteron
> bool "opteron"
> select BR2_X86_CPU_HAS_MMX
> @@ -430,68 +448,24 @@ config BR2_x86_geode
> # Don't include MMX support because there several variant of geode
> # processor, some with MMX support, some without.
> # See: http://en.wikipedia.org/wiki/Geode_%28processor%29
> + depends on !BR2_x86_64
> config BR2_x86_c3
> bool "Via/Cyrix C3 (Samuel/Ezra cores)"
> select BR2_X86_CPU_HAS_MMX
> + depends on !BR2_x86_64
> config BR2_x86_c32
> bool "Via C3-2 (Nehemiah cores)"
> select BR2_X86_CPU_HAS_MMX
> select BR2_X86_CPU_HAS_SSE
> + depends on !BR2_x86_64
> config BR2_x86_winchip_c6
> bool "IDT Winchip C6"
> select BR2_X86_CPU_HAS_MMX
> + depends on !BR2_x86_64
> config BR2_x86_winchip2
> bool "IDT Winchip 2"
> select BR2_X86_CPU_HAS_MMX
> -endchoice
> -
> -choice
> - prompt "Target Architecture Variant"
> - depends on BR2_x86_64
> - default BR2_x86_64_generic
> - help
> - Specific CPU variant to use
> -
> -config BR2_x86_64_generic
> - bool "generic"
> -config BR2_x86_64_barcelona
> - bool "barcelona"
> - select BR2_X86_CPU_HAS_MMX
> - select BR2_X86_CPU_HAS_3DNOW
> - select BR2_X86_CPU_HAS_SSE
> - select BR2_X86_CPU_HAS_SSE2
> - select BR2_X86_CPU_HAS_SSE3
> -config BR2_x86_64_opteron_sse3
> - bool "opteron w/ sse3"
> - select BR2_X86_CPU_HAS_MMX
> - select BR2_X86_CPU_HAS_SSE
> - select BR2_X86_CPU_HAS_SSE2
> - select BR2_X86_CPU_HAS_SSE3
> -config BR2_x86_64_opteron
> - bool "opteron"
> - select BR2_X86_CPU_HAS_MMX
> - select BR2_X86_CPU_HAS_SSE
> - select BR2_X86_CPU_HAS_SSE2
> -config BR2_x86_64_nocona
> - bool "nocona"
> - select BR2_X86_CPU_HAS_MMX
> - select BR2_X86_CPU_HAS_SSE
> - select BR2_X86_CPU_HAS_SSE2
> - select BR2_X86_CPU_HAS_SSE3
> -config BR2_x86_64_core2
> - bool "core2"
> - select BR2_X86_CPU_HAS_MMX
> - select BR2_X86_CPU_HAS_SSE
> - select BR2_X86_CPU_HAS_SSE2
> - select BR2_X86_CPU_HAS_SSE3
> - select BR2_X86_CPU_HAS_SSSE3
> -config BR2_x86_64_atom
> - bool "atom"
> - select BR2_X86_CPU_HAS_MMX
> - select BR2_X86_CPU_HAS_SSE
> - select BR2_X86_CPU_HAS_SSE2
> - select BR2_X86_CPU_HAS_SSE3
> - select BR2_X86_CPU_HAS_SSSE3
> + depends on !BR2_x86_64
> endchoice
>
> choice
> @@ -676,16 +650,17 @@ config BR2_ARCH
> default "i686" if BR2_x86_pentium_m
> default "i686" if BR2_x86_pentiumpro
> default "i686" if BR2_x86_prescott
> - default "i686" if BR2_x86_nocona
> - default "i686" if BR2_x86_core2
> - default "i686" if BR2_x86_atom
> - default "i686" if BR2_x86_opteron
> - default "i686" if BR2_x86_opteron_sse3
> - default "i686" if BR2_x86_barcelona
> + default "i686" if BR2_x86_nocona && BR2_i386
> + default "i686" if BR2_x86_core2 && BR2_i386
> + default "i686" if BR2_x86_atom && BR2_i386
> + default "i686" if BR2_x86_opteron && BR2_i386
> + default "i686" if BR2_x86_opteron_sse3 && BR2_i386
> + default "i686" if BR2_x86_barcelona && BR2_i386
> default "i686" if BR2_x86_k6
> default "i686" if BR2_x86_k6_2
> default "i686" if BR2_x86_athlon
> default "i686" if BR2_x86_athlon_4
> + default "x86_64" if BR2_x86_64
> default "m68k" if BR2_m68k
> default "microblaze" if BR2_microblaze
> default "mips" if BR2_mips
> @@ -701,14 +676,6 @@ config BR2_ARCH
> default "sh4aeb" if BR2_sh4aeb
> default "sh64" if BR2_sh64
> default "sparc" if BR2_sparc
> - default "x86_64" if BR2_x86_64
> - default "x86_64" if BR2_x86_64_generic
> - default "x86_64" if BR2_x86_64_nocona
> - default "x86_64" if BR2_x86_64_core2
> - default "x86_64" if BR2_x86_64_atom
> - default "x86_64" if BR2_x86_64_opteron
> - default "x86_64" if BR2_x86_64_opteron_sse3
> - default "x86_64" if BR2_x86_64_barcelona
> default "xtensa" if BR2_xtensa
>
>
> @@ -750,13 +717,7 @@ config BR2_GCC_TARGET_TUNE
> default c3 if BR2_x86_c3
> default c3-2 if BR2_x86_c32
> default geode if BR2_x86_geode
> - default generic if BR2_x86_64_generic
> - default nocona if BR2_x86_64_nocona
> - default core2 if BR2_x86_64_core2
> - default atom if BR2_x86_64_atom
> - default k8 if BR2_x86_64_opteron
> - default k8-sse3 if BR2_x86_64_opteron_sse3
> - default barcelona if BR2_x86_64_barcelona
> + default generic if BR2_x86_generic
> default arm600 if BR2_arm600
> default arm610 if BR2_arm610
> default arm620 if BR2_arm620
> @@ -864,12 +825,6 @@ config BR2_GCC_TARGET_ARCH
> default athlon-4 if BR2_x86_athlon_4
> default winchip-c6 if BR2_x86_winchip_c6
> default winchip2 if BR2_x86_winchip2
> - default nocona if BR2_x86_64_nocona
> - default core2 if BR2_x86_64_core2
> - default atom if BR2_x86_64_atom
> - default k8 if BR2_x86_64_opteron
> - default k8-sse3 if BR2_x86_64_opteron_sse3
> - default barcelona if BR2_x86_64_barcelona
> default c3 if BR2_x86_c3
> default c3-2 if BR2_x86_c32
> default geode if BR2_x86_geode
> diff --git a/toolchain/gcc/Config.in b/toolchain/gcc/Config.in
> index fa526bb..d08efbc 100644
> --- a/toolchain/gcc/Config.in
> +++ b/toolchain/gcc/Config.in
> @@ -15,11 +15,11 @@ choice
> bool "gcc 4.2.2-avr32-2.1.5"
>
> config BR2_GCC_VERSION_4_3_X
> - depends on !BR2_avr32 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_cortex_a8 && !BR2_cortex_a9 && !BR2_x86_atom && !BR2_x86_64_atom && !BR2_powerpc_e300c2 && !BR2_powerpc_e300c3 && !BR2_powerpc_e500mc
> + depends on !BR2_avr32 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_cortex_a8 && !BR2_cortex_a9 && !BR2_x86_atom && !BR2_powerpc_e300c2 && !BR2_powerpc_e300c3 && !BR2_powerpc_e500mc
> bool "gcc 4.3.x"
>
> config BR2_GCC_VERSION_4_4_X
> - depends on !BR2_avr32 && !BR2_x86_atom && !BR2_x86_64_atom
> + depends on !BR2_avr32 && !BR2_x86_atom
> bool "gcc 4.4.x"
>
> config BR2_GCC_VERSION_4_5_X
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-26 19:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 20:47 [Buildroot] [PATCH] Clarify MIPS ABIs support Thomas Petazzoni
2012-07-25 16:29 ` Thomas Petazzoni
2012-07-25 17:32 ` Arnout Vandecappelle
2012-07-25 18:25 ` Thomas Petazzoni
2012-07-25 18:31 ` Thomas Petazzoni
2012-07-25 19:15 ` Thomas Petazzoni
2012-07-26 16:38 ` Arnout Vandecappelle
2012-07-27 6:31 ` Thomas Petazzoni
2012-07-26 19:01 ` Thomas Petazzoni [this message]
2012-07-26 19:38 ` Gustavo Zacarias
2012-07-27 6:56 ` Thomas Petazzoni
2012-07-27 10:17 ` Gustavo Zacarias
2012-07-25 20:25 ` Gustavo Zacarias
2012-07-25 20:38 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726210102.6f65719c@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox