From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 30 Jul 2012 22:56:45 +0200 Subject: [Buildroot] [PATCH 3/4] lua: remove 3 sub-options, always install all In-Reply-To: <1343629890-4657-3-git-send-email-francois.perrad@gadz.org> References: <1343629890-4657-1-git-send-email-francois.perrad@gadz.org> <1343629890-4657-3-git-send-email-francois.perrad@gadz.org> Message-ID: <20120730225645.6ed17e9f@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Le Mon, 30 Jul 2012 08:31:29 +0200, Francois Perrad a ?crit : > --- > package/lua/Config.in | 18 ------------------ > package/lua/lua.mk | 17 +---------------- > 2 files changed, 1 insertion(+), 34 deletions(-) > > diff --git a/package/lua/Config.in b/package/lua/Config.in > index 06f3046..fc6bb4c 100644 > --- a/package/lua/Config.in > +++ b/package/lua/Config.in > @@ -32,29 +32,11 @@ endchoice > > if BR2_PACKAGE_LUA > > -config BR2_PACKAGE_LUA_COMPILER > - bool "lua compiler" > - select BR2_PACKAGE_LUA_SHARED_LIBRARY > - help > - Install luac binary > - > -config BR2_PACKAGE_LUA_INTERPRETER > - bool "lua interpreter" > - select BR2_PACKAGE_LUA_SHARED_LIBRARY > - help > - Install lua binary Wouldn't it make sense to keep options for the compiler and interpreter? I presume using the compiler on the target is fairly uncommon (you would rather do the compilation at build time, no?). And Lua can be used as a library without the separate /usr/bin/lua interpreter, no? But maybe this last option (the interpreter) is more complicated to handle with the choice between lua and luajit. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com