Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] buildroot: Makefile: Allow target board makefile fill in default target_skeleton path.
Date: Thu, 9 Aug 2012 10:41:55 +0200	[thread overview]
Message-ID: <20120809104155.563af2a2@skate> (raw)
In-Reply-To: <1344409039-32071-1-git-send-email-sonic.adi@gmail.com>

Le Wed, 8 Aug 2012 14:57:19 +0800,
Sonic Zhang <sonic.adi@gmail.com> a ?crit :

> If the target skeleton path is empty in config, don't change variable
> TARGET_SKELETON in buildroot Makefile. Allow the target board makefile
> fill in a default path.

The concept of "target board makefile" does not exist. It used to exist
in earlier versions of Buildroot, but it no longer exists in newer
versions. Thus, I have the feeling that rather than fixing this, it is
the way your boards are supported that should be modified according to
the newer Buildroot good practices.

The practices in terms of board support are:

 * One defconfig file per board in configs/, generally named
   <vendor>_<boardname>_defconfig. Those files must be generated with
   'make savedefconfig'

 * Utility files (kernel patches, kernel configuration files and other
   stuff), should be stored in board/<vendor>/<boardname>/. Kernel
   configuration files must be generated with 'make savedefconfig' as
   well.

 * Using a different skeleton from the default one provided by
   Buildroot is really *not* recommended. Instead, if anything needs to
   be tweaked in the filesystem, use the post-build script for that
   effect. This allows to avoid duplicating the skeleton for each and
   every board, causing a maintenance nightmare when we want to change
   something in this skeleton.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-08-09  8:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08  6:57 [Buildroot] [PATCH] buildroot: Makefile: Allow target board makefile fill in default target_skeleton path Sonic Zhang
2012-08-09  8:41 ` Thomas Petazzoni [this message]
2012-08-09 10:26   ` Sonic Zhang
2012-08-09 20:44     ` Thomas Petazzoni
2012-08-13  5:04       ` Sonic Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120809104155.563af2a2@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox