Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/5] buildroot: patch kernel by kernel version
Date: Sat, 11 Aug 2012 20:08:24 +0200	[thread overview]
Message-ID: <20120811200824.0293829b@skate> (raw)
In-Reply-To: <1344330577-25159-3-git-send-email-sonic.adi@gmail.com>

Le Tue, 7 Aug 2012 17:09:35 +0800,
Sonic Zhang <sonic.adi@gmail.com> a ?crit :

> +KERNELVERSION=$(shell cat $(LINUX_SOURCE_DIR)/Makefile | awk 'BEGIN { FS = " *= *" }  NF != 2 { next } $$1 == "VERSION" { maj = $$2} $$1 == "PATCHLEVEL" { mid = $$2 } $$1 == "SUBLEVEL" { mic = $$2 } END {print maj "." mid "." mic}')

This sounds horribly fragile.

>  ifeq ($(BR2_LINUX_KERNEL_USE_INTREE_DTS),y)
>  KERNEL_DTS_NAME = $(BR2_LINUX_KERNEL_INTREE_DTS_NAME)
>  else ifeq ($(BR2_LINUX_KERNEL_USE_CUSTOM_DTS),y)
> @@ -149,7 +151,7 @@ define LINUX_APPLY_PATCHES
>  		if echo $$p | grep -q -E "^ftp://|^http://" ; then \
>  			support/scripts/apply-patches.sh $(LINUX_SOURCE_DIR) $(DL_DIR) `basename $$p` ; \
>  		elif test -d $$p ; then \
> -			support/scripts/apply-patches.sh $(LINUX_SOURCE_DIR) $$p linux-\*.patch ; \
> +			support/scripts/apply-patches.sh $(LINUX_SOURCE_DIR) $$p linux-$(KERNELVERSION)-\*.patch ; \

Generally, we want to move away from patches having a version number in
their name. For the packages for which multiple versions are supported,
the patches should be organized in subdirectories named after the
version. So instead of this patch, just organize your kernel patches in
directories named linux-patches-3.2/, linux-patches-3.4/, etc.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-08-11 18:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  9:09 [Buildroot] [PATCH 1/5] buildroot:linux: Rename blackfin kernel Image file from vmImage back to uImage Sonic Zhang
2012-08-07  9:09 ` [Buildroot] [PATCH 2/5] linux: support unpacked kernel source tree Sonic Zhang
2012-08-11 18:06   ` Thomas Petazzoni
2012-08-13 10:12     ` Sonic Zhang
2012-08-13 17:27       ` Thomas Petazzoni
2012-08-14  8:44         ` Sonic Zhang
2012-08-07  9:09 ` [Buildroot] [PATCH 3/5] buildroot: patch kernel by kernel version Sonic Zhang
2012-08-11 18:08   ` Thomas Petazzoni [this message]
2012-08-13 10:13     ` Sonic Zhang
2012-08-07  9:09 ` [Buildroot] [PATCH 4/5] Linux: Unpatch customer kernel source tree before make clean Sonic Zhang
2012-08-11 18:11   ` Thomas Petazzoni
2012-08-13 10:21     ` Sonic Zhang
2012-08-07  9:09 ` [Buildroot] [PATCH 5/5] buildroot: initramfs: Generate vmImage without builtin initramfs rootfs Sonic Zhang
2012-08-11 18:13   ` Thomas Petazzoni
2012-08-13 10:32     ` Sonic Zhang
2012-08-21 22:49       ` Arnout Vandecappelle
2012-08-11 18:04 ` [Buildroot] [PATCH 1/5] buildroot:linux: Rename blackfin kernel Image file from vmImage back to uImage Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120811200824.0293829b@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox