From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Fri, 17 Aug 2012 13:14:32 +0200 Subject: [Buildroot] [PATCH 05/36] package/libiscsi: new package In-Reply-To: <1344815664-28138-5-git-send-email-yann.morin.1998@free.fr> References: <1344815664-28138-1-git-send-email-yann.morin.1998@free.fr> <1344815664-28138-5-git-send-email-yann.morin.1998@free.fr> Message-ID: <20120817131432.205de8e1@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Le Mon, 13 Aug 2012 01:53:53 +0200, "Yann E. MORIN" a ?crit : > +LIBISCSI_VERSION = 1.5.0 > +LIBISCSI_SITE = git://github.com/sahlberg/libiscsi.git You can instead use https://github.com/sahlberg/libiscsi/zipball/$(LIBISCI_VERSION) which will download a zip file of the project. > +LIBISCSI_LICENSE = LGPLv2.1+ > +LIBISCSI_LICENSE_FILES = COPYING LICENCE-LGPL-2.1.txt > +#?Note: the binaries are GPLv2+, but we do not use them > +LIBISCSI_INSTALL_STAGING = YES > +LIBISCSI_DEPENDENCIES = popt > + > +#---------------------------------------------------------------------------- > +# Package build process > + > +# As we use the git repository, we need to generate the configure script > +# Using the standard autoreconf does not work (missing m4/ dir) > +define LIBISCSI_CREATE_CONFIGURE > + cd $(@D); ./autogen.sh > +endef > +LIBISCSI_PRE_CONFIGURE_HOOKS += LIBISCSI_CREATE_CONFIGURE > +LIBISCSI_DEPENDENCIES += host-autoconf host-autoconf will not bring host-automake, so I think you should either depend on host-automake (which itself depends on host-autoconf), or you should do like the autotools package infrastructure does: FOO_DEPENDENCIES += host-automake host-autoconf host-libtool. Or, you can do something like: LIBISCSI_AUTORECONF = YES # Having a m4/ directory is mandatory for autoreconf to work define LIBISCSI_CREATE_M4_DIR mkdir -p $(@D)/m4 endef LIBISCSI_PRE_CONFIGURE_HOOKS += LIBISCSI_CREATE_M4_DIR I don't have a strong opinion between those two solutions. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com