From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] libdvdnav: Fix dvdnav-config
Date: Wed, 26 Sep 2012 22:46:34 +0200 [thread overview]
Message-ID: <20120926224634.7bddf310@skate> (raw)
In-Reply-To: <20120926193351.GA3971@gmail.com>
Dear Valentine Barshak,
On Wed, 26 Sep 2012 23:33:51 +0400, Valentine Barshak wrote:
> +ifneq ($(BR2_HAVE_DEVFILES),y)
> +LIBDVDNAV_POST_INSTALL_TARGET_HOOKS += LIBDVDNAV_TARGET_CLEANUP
> +endif
We generally prefer positive logic:
ifeq ($(BR2_HAVE_DEVFILES),)
...
endif
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-09-26 20:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 19:31 [Buildroot] [PATCH 0/3] Fix libdvdread and libdvdnav support Valentine Barshak
2012-09-26 19:33 ` [Buildroot] [PATCH 1/3] libdvdread: Fix dvdread-config Valentine Barshak
2012-09-26 19:33 ` [Buildroot] [PATCH 2/3] libdvdnav: Fix dvdnav-config Valentine Barshak
2012-09-26 20:46 ` Thomas Petazzoni [this message]
2012-09-26 21:05 ` vaxon
2012-09-26 19:34 ` [Buildroot] [PATCH 3/3] mplayer: Fix external libdvdread and libdvdnav support Valentine Barshak
2012-09-26 20:46 ` Thomas Petazzoni
2012-09-26 20:59 ` vaxon
[not found] ` <50636C68.5030601@gmail.com>
2012-09-27 12:25 ` Valentine Barshak
2012-09-27 12:37 ` Thomas Petazzoni
2012-09-27 18:09 ` Valentine Barshak
2012-10-04 21:27 ` [Buildroot] [PATCH 0/3] Fix " Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2012-09-27 18:13 [Buildroot] [PATCH 0/3] Fix libdvdread and libdvdnav support v2 Valentine Barshak
2012-09-27 18:17 ` [Buildroot] [PATCH 2/3] libdvdnav: Fix dvdnav-config Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926224634.7bddf310@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox