Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Support for package liblog4c-localtime
Date: Fri, 28 Sep 2012 19:27:32 +0200	[thread overview]
Message-ID: <20120928192732.69a9c393@skate> (raw)
In-Reply-To: <5065CE40.70500@mail.ru>

Dear Alexander Varnin,

On Fri, 28 Sep 2012 20:20:16 +0400, Alexander Varnin wrote:

> Sorry, forget to include patch file.

Please don't send patches as attached files, because we can't easily
comment on them. If you want to send patches properly, use the 'git
send-email' tool.

A few comments:

 * You're specifying a LIBLOG4C_SOURCE variable, but this variable is
   ignored because your LIBLOG4C_SITE starts with git://. You have to
   decide whether you want a tarball download (so LIBLOG4C_SOURCE
   should be a tarball name, and LIBLOG4C_SITE should be a http or ftp
   url) or if you want a Git download (so LIBLOG4C_SOURCE should not be
   set, and LIBLOG4C_SITE should point to a Git repository)

 * LIBLOG4C_INSTALL_STAGING should be set to YES. Your package is a
   library, and you are defining the <foo>_INSTALL_STAGING_CMDS
   variable.

 * Looking at https://github.com/rcmadruga/log4c-localtime, this
   package seems to use the autotools, so you should be using the
   autotools-package infrastructure, and most likely you don't need to
   define any of the LIBLOG4C_BUILD_CMDS, LIBLOG4C_INSTALL_STAGING_CMDS
   and LIBLOG4C_INSTALL_TARGET_CMDS variables.

 * There should not be a commented line in your
   <foo>_INSTALL_TARGET_CMDS variable. Ditto for <foo>_DEVICES and
   <foo>_PERMISSIONS.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-09-28 17:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28 16:18 [Buildroot] Support for package liblog4c-localtime Alexander Varnin
2012-09-28 16:20 ` Alexander Varnin
2012-09-28 17:27   ` Thomas Petazzoni [this message]
     [not found]     ` <5066ADF5.9070609@mail.ru>
2012-09-29  8:39       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120928192732.69a9c393@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox