From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 RESEND-2] pkg-infra: make sure cross compiling is enabled when host == target
Date: Thu, 4 Oct 2012 21:57:48 +0200 [thread overview]
Message-ID: <20121004215748.3d09616a@skate> (raw)
In-Reply-To: <1349256390-9956-1-git-send-email-arnout@mind.be>
Peter,
Could you apply this one? It has been around for a very long time.
Thanks!
Thomas
On Wed, 3 Oct 2012 11:26:30 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> When compiling for the same architecture and libc as the host,
> GNU_TARGET_NAME and GNU_HOST_NAME are equal. configure scripts use
> these to detect cross-compilation, and will decide that we're doing
> native compilation. This may trigger running of executables,
> which fail because of missing libraries in the host environment.
>
> To solve this, set the vendor part in GNU_TARGET_NAME to buildroot.
>
> This problem exists for instance in xserver_xorg-server on x86_64.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> RESEND I hit this again while compiling xserver_xorg-server...
> RESEND-2 And again, after testing the xorg updates.
> Added ThomasP's Acked-by as well.
>
> v3: modify GNU_TARGET_NAME instead of GNU_HOST_NAME, which makes a lot
> more sense of course. Thank you ThomasP!
>
> I only tested this one with xserver_xorg-server on a Sourcery
> x86_64 toolchain and with a simple config and an internal
> toolchain.
>
> v2: -buildroot- instead of -buildroot_cross-, as suggested by ThomasP.
>
> package/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index 64508b2..30a542a 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -20,7 +20,7 @@ MAKE1:=$(HOSTMAKE) -j1
> MAKE:=$(HOSTMAKE) -j$(PARALLEL_JOBS)
>
> # Compute GNU_TARGET_NAME
> -GNU_TARGET_NAME=$(ARCH)-unknown-linux-$(LIBC)$(ABI)
> +GNU_TARGET_NAME=$(ARCH)-buildroot-linux-$(LIBC)$(ABI)
>
> ifeq
> ($(BR2_TOOLCHAIN_BUILDROOT)$(BR2_TOOLCHAIN_CTNG_uClibc)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC),y)
> LIBC=uclibc
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-04 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 22:42 [Buildroot] [PATCH v3 RESEND] pkg-infra: make sure cross compiling is enabled when host == target Arnout Vandecappelle
2012-09-26 7:25 ` Thomas Petazzoni
2012-10-03 9:26 ` [Buildroot] [PATCH v3 RESEND-2] " Arnout Vandecappelle
2012-10-04 19:57 ` Thomas Petazzoni [this message]
2012-10-04 20:50 ` Peter Korsgaard
2012-10-04 20:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004215748.3d09616a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox