From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] keyutils: new package
Date: Wed, 24 Oct 2012 23:06:38 +0200 [thread overview]
Message-ID: <201210242306.38368.yann.morin.1998@free.fr> (raw)
In-Reply-To: <1351112292-5617-1-git-send-email-jarkko.sakkinen@iki.fi>
Jarkko, All,
On Wednesday 24 October 2012 Jarkko Sakkinen wrote:
> Linux key management utilities
There are two memleaks known in keyutils.
I'm about to post a patch series that includes keyutils
with patches to fix the memleaks.
[--SNIP--]
> diff --git a/package/keyutils/keyutils.mk b/package/keyutils/keyutils.mk
> new file mode 100644
> index 0000000..82b1f58
> --- /dev/null
> +++ b/package/keyutils/keyutils.mk
> @@ -0,0 +1,28 @@
> +#############################################################
> +#
> +# keyutils
> +#
> +#############################################################
> +
> +KEYUTILS_VERSION = 1.5.5
> +KEYUTILS_SITE = http://people.redhat.com/dhowells/keyutils/
> +KEYUTILS_SOURCE = keyutils-$(KEYUTILS_VERSION).tar.bz2
> +
> +define KEYUTILS_BUILD_CMDS
> + $(MAKE) CFLAGS="$(TARGET_CFLAGS)" LDFLAGS="$(TARGET_LDFLAGS)" \
> + CC="$(TARGET_CC)" -C $(@D)
> +endef
I have:
define KEYUTILS_BUILD_CMDS
$(KEYUTILS_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
endef
Which includes all our CFLAGS, while doing the way you did overrides the
CFLAGS in keytuils' Makefile, and breaks (at least for me on one arch).
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2012-10-24 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 20:58 [Buildroot] [PATCH] keyutils: new package Jarkko Sakkinen
2012-10-24 21:06 ` Yann E. MORIN [this message]
2012-10-24 22:27 ` Yann E. MORIN
2012-10-25 5:23 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210242306.38368.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox