From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] neard: new package
Date: Fri, 9 Nov 2012 14:20:44 +0100 [thread overview]
Message-ID: <20121109142044.09933dfa@skate> (raw)
In-Reply-To: <1352459105-13590-2-git-send-email-spdawson@gmail.com>
On Fri, 9 Nov 2012 11:05:04 +0000, spdawson at gmail.com wrote:
> diff --git a/package/neard/Config.in b/package/neard/Config.in
> new file mode 100644
> index 0000000..f973fdd
> --- /dev/null
> +++ b/package/neard/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_NEARD
> + bool "neard"
> + depends on BR2_LINUX_KERNEL
Why this dependency?
> + select BR2_PACKAGE_DBUS
> + select BR2_PACKAGE_LIBGLIB2
> + select BR2_PACKAGE_LIBNL
> + help
> + Near Field Communication (NFC) manager
A slightly longer description would be useful here.
> +
> + http://git.kernel.org/?p=network/nfc/neard.git;a=summary
> +
> + https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...
Those "..." at the end look strange.
> diff --git a/package/neard/neard.mk b/package/neard/neard.mk
> new file mode 100644
> index 0000000..3d73932
> --- /dev/null
> +++ b/package/neard/neard.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# neard
> +#
> +#############################################################
> +NEARD_VERSION = 0.7
> +NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
> +NEARD_INSTALL_STAGING = YES
> +NEARD_LICENSE = GPLv2
> +NEARD_LICENSE_FILES = COPYING
> +
> +NEARD_DEPENDENCIES = linux dbus libglib2 libnl
> +NEARD_AUTORECONF = YES
The package does not have any patches, and is downloaded from a
tarball. Why is an autoreconf needed?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-09 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 11:05 [Buildroot] [PATCH 0/2] Add neard and neardal packages spdawson at gmail.com
2012-11-09 11:05 ` [Buildroot] [PATCH 1/2] neard: new package spdawson at gmail.com
2012-11-09 13:20 ` Thomas Petazzoni [this message]
2012-11-09 13:36 ` Simon Dawson
2012-11-09 11:05 ` [Buildroot] [PATCH 2/2] neardal: " spdawson at gmail.com
2012-11-10 2:12 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121109142044.09933dfa@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox