From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] arch: improve definition of gcc mtune, mcpu, etc.
Date: Thu, 15 Nov 2012 14:54:20 +0100 [thread overview]
Message-ID: <20121115145420.64205ba0@skate> (raw)
In-Reply-To: <201211151438.30221.yann.morin.1998@free.fr>
On Thu, 15 Nov 2012 14:38:30 +0100, Yann E. MORIN wrote:
> I know you are just moving stuff around, but those symbols are typed
> as strings, so the default values should be enclosed in-between double
> quotes:
> default "arm600" if BR2_arm600
>
> Moreover, the code is not coherent with itslef, even in a single file.
> For example, you have (both are string symbols):
>
> config BR2_ENDIAN
> default "LITTLE" if BR2_arm
>
> config BR2_GCC_TARGET_TUNE
> default arm600 if BR2_arm600
>
> That it currently works is just happenstance, and may well break in
> the future when we upgrade to a newer kconfig version.
>
> Maybe we can just apply this for now, and fix that in a future patch?
I sent a new pull request, which includes a patch fixing this problem.
Thanks for reminding me about it!
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-15 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 13:30 [Buildroot] [pull request] Pull request for branch xtensa Thomas Petazzoni
2012-11-15 13:30 ` [Buildroot] [PATCH 1/5] arch: improve definition of gcc mtune, mcpu, etc Thomas Petazzoni
2012-11-15 13:38 ` Yann E. MORIN
2012-11-15 13:54 ` Thomas Petazzoni [this message]
2012-11-15 13:30 ` [Buildroot] [PATCH 2/5] uClibc: remove useless linuxthreads-errno-fix patch Thomas Petazzoni
2012-11-15 13:30 ` [Buildroot] [PATCH 3/5] uClibc: update uClibc-snapshot.config to recent uClibcs Thomas Petazzoni
2012-11-15 13:30 ` [Buildroot] [PATCH 4/5] xtensa: add support for the Xtensa architecture Thomas Petazzoni
2012-11-15 13:30 ` [Buildroot] [PATCH 5/5] xtensa: support configurable processor configurations Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115145420.64205ba0@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox