Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Generating patches against packages source code
Date: Sat, 29 Dec 2012 19:03:06 +0100	[thread overview]
Message-ID: <201212291903.06705.yann.morin.1998@free.fr> (raw)
In-Reply-To: <20121229171540.5bb22f40@skate>

Stefan, Thomas, All,

On Saturday 29 December 2012 Thomas Petazzoni wrote:
> On Sat, 29 Dec 2012 16:56:51 +0200, Stefan Fr?berg wrote:
> > That's what I meant. Those *inside* Signed-off tags.
> > How should I add those inside Signed-off tags to individual patches
> > (either my own make or 3rd party)
> > applied to mesa3d ?
[--SNIP--]
> So basically, you have three choices (ordered below from the poorest to
> the nicest, in my opinion).
> 
> 1. Use the raw diff tool
[--SNIP--]
> And then, edit mesa3d-01-something.patch with your text editor to add
> the patch description and the Signed-off-by line.

I am using vim as editor, and I use the snippet 'plugin'. To add any
SoB-like line, I just have to type:
    sob<TAB>me<TAB>
and I get:
    Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Similarly, I have snippets configured for:
    Reported-by:
    Reviewed-by:
    Acked-by:
    Tested-by:
    CC:  (although that one is a bit overkill ;-) )

Snippets available, anyone wants them.

> 2. Use quilt

I've found using quilt to be troublesome. For example, you absolutely have
to tell quilt what files you are *going* to edit, otherwise, quilt will
miss your changes. And this situation happens more often than not; in my
experience, it happened quite often that I edited a file because I _knew_
where the failure was, to later find I forgot to tell quilt about that
file, and was missing that change in the patch series.

So, I would recommend against using quilt; rather use the package's
upstream repository, or at worse, create a temporary git tree just in
the package's extracted directory: it's much more convenient and
powerfull than using quilt.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2012-12-29 18:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-29  1:45 [Buildroot] (no subject) Stefan Fröberg
2012-12-29  1:45 ` [Buildroot] [PATCH 1/5] mesa3d: bumped to 8.0.5 Stefan Fröberg
2012-12-29  8:06   ` Thomas Petazzoni
2012-12-29 13:06     ` Stefan Fröberg
2012-12-29  1:45 ` [Buildroot] [PATCH 2/5] " Stefan Fröberg
2012-12-29  8:07   ` Thomas Petazzoni
2012-12-29  1:45 ` [Buildroot] [PATCH 3/5] " Stefan Fröberg
2012-12-29  8:08   ` Thomas Petazzoni
2012-12-29  1:45 ` [Buildroot] [PATCH 4/5] " Stefan Fröberg
2012-12-29  1:45 ` [Buildroot] [PATCH 5/5] " Stefan Fröberg
2012-12-29  8:08   ` Thomas Petazzoni
2012-12-29  7:59 ` [Buildroot] (no subject) Thomas Petazzoni
2012-12-29 14:13   ` Stefan Fröberg
2012-12-29 14:32     ` Thomas Petazzoni
2012-12-29 14:56       ` Stefan Fröberg
2012-12-29 15:23         ` [Buildroot] (no subject) git format-patch Carsten Schoenert
2012-12-29 15:31           ` Stefan Fröberg
2012-12-29 16:15         ` [Buildroot] Generating patches against packages source code Thomas Petazzoni
2012-12-29 16:54           ` Stefan Fröberg
2012-12-29 17:09             ` Richard Braun
2012-12-29 17:13               ` Thomas Petazzoni
2012-12-29 17:33                 ` Richard Braun
2012-12-29 18:03           ` Yann E. MORIN [this message]
2012-12-29 18:39             ` Thomas Petazzoni
2012-12-29 19:04               ` Stefan Fröberg
2012-12-29 19:56                 ` Yann E. MORIN
2012-12-29 20:18                   ` Stefan Fröberg
2012-12-29 19:52               ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201212291903.06705.yann.morin.1998@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox