Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] perf: new package
Date: Fri, 4 Jan 2013 09:22:43 +0100	[thread overview]
Message-ID: <20130104092243.47bb447e@skate> (raw)
In-Reply-To: <CAPDLWs_+GNS6EtzWVt98wwDiDwnqVc+BvAQm31+5ib62-bGQ4A@mail.gmail.com>

Dear Kaiwan Billimoria,

On Fri, 4 Jan 2013 11:35:56 +0530, Kaiwan Billimoria wrote:

> Just checking / asking:
> 1. what about the kernel patch to be applied such that kernel build
> for perf is successful (i sent in the patch yesterday)

It apparently wasn't needed to build perf on a 3.7 kernel.

> 2. In my patch (linux.mk), I make a validity check to confirm that the
> kernel version is >= 2.6.31 (as perf is only supported from that ver
> onward). Should we keep that check?

For now, I did not introduce it, due to the fact that the kernel
versions for which perf is usable are not clear yet. According to you,
it's 2.6.31, according to me it's 3.7. Once we figure that out, we can
introduce a version check if needed.

> 3. You mention :
> > the NO_LIBELF variable, which allows to get rid of the libelf dependency,
> > has only been introduced between 3.6 and 3.7.
> I did test my patches on the 3.2.21 vanilla kernel and it seems to work okay..

Here is the tools/perf/Makefile from 3.2.21 :
https://git.kernel.org/?p=linux/kernel/git/bwh/linux-3.2.y.git;a=blob;f=tools/perf/Makefile;h=b98e3075646b43f8f3218f45289f65068ea7ef31;hb=8499e79e9ee4c946ae38fd12e5d3afe8b68f2dfd

As you can see, it does not understand the NO_LIBELF variable, but
requires the libelf library to be present. So I'm not sure how you
manage to build perf without libelf with 3.2.21.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2013-01-04  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 15:07 [Buildroot] [PATCH] perf: new package Thomas Petazzoni
2013-01-03 15:24 ` Stefan Fröberg
2013-01-03 15:48   ` Stefan Fröberg
2013-01-03 23:22   ` Thomas Petazzoni
2013-01-04 14:01     ` Stefan Fröberg
2013-01-04 14:25     ` Stefan Fröberg
2013-01-04 14:27       ` Thomas Petazzoni
2013-01-04  6:05 ` Kaiwan Billimoria
2013-01-04  8:22   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130104092243.47bb447e@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox