Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1 V2] cairo : bump version to 1.12.8
Date: Sun, 13 Jan 2013 18:56:34 +0100	[thread overview]
Message-ID: <20130113185634.08a6f635@skate> (raw)
In-Reply-To: <1358097082-24212-1-git-send-email-sagaert.johan@skynet.be>

Dear Sagaert Johan,

On Sun, 13 Jan 2013 18:11:22 +0100, Sagaert Johan wrote:
> 
> Patch v2 : The patch for 1.10.2 is no longer needed with cairo version 1.12.8.

Why? Has it been merged upstream?

Also, your commit log is still improperly formatted. Please look
*carefully*:

==
cairo: bump to version 1.12.8

The patch for 1.10.2 is no longer needed with cairo version 1.12.8

Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
---
Changes since v1:
 - Explain why patch is no longer needed
==

So:

 * There must be *ONE* and only *ONE* empty line between the commit
   title ("cairo: bump ...") and the core of the commit log. You always
   put two newlines, this is useless.

 * There must be *ONE* and only *ONE* empty line between the last
   paragraph of the commit log and the Signed-off-by line.

 * The changelog (which explain the change since the previous versions
   of your patch) must be after the --- marker so that the contents of
   the changelog is not kept in history.

Please look carefully at how other do patches, and try to do the same.
This will avoid you the need to send gazillions of versions of the same
patch just because of basic formatting problems.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-01-13 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 17:11 [Buildroot] [PATCH 1/1 V2] cairo : bump version to 1.12.8 Sagaert Johan
2013-01-13 17:56 ` Thomas Petazzoni [this message]
2013-01-14  9:59 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130113185634.08a6f635@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox