From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] need help adding apache to buildroot
Date: Fri, 18 Jan 2013 16:31:04 +0100 [thread overview]
Message-ID: <20130118163104.441c2bfb@skate> (raw)
In-Reply-To: <2495590.Ukzi9HXY20@sagittae>
Dear J?r?me Pouiller,
On Fri, 18 Jan 2013 10:25:03 +0100, J?r?me Pouiller wrote:
> On Thursday 17 January 2013 22:41:24 Jenkins, Lee wrote:
> [...]
> > The good news is I found a patch that provides a CC_FOR_BUILD variable to
> > fix the problem. However, the patch is not an "official" apache patch, but
> > hosted at a different location here:
> > http://people.apache.org/~fuankg/diffs/httpd-2.2.x-cross_compile.diff. If
> > I'm reading the buildroot docs correctly, if I add APACHE_PATCH to
> > apache.mk it will require the patch to be at the same URL as the tarball.
> > Ugh.
> >
> > Are the "patch hooks" simply shell commands? How egregious would it be (from
> > a buildroot maintainer perspective) to use the patch hooks to wget the
> > patch and apply it? :-)
> IMHO, this patch is small enough to be included in Buildroot tree.
>
> Download manually the patch, place it in your package directory and name it
> RAWNAME-DESCRIPTION.patch (apache-cross-compile-fix.patch) (Exact naming rule
> is in packages/pkg-generic.mk:$(BUILD_DIR)/%/.stamp_patched).
>
> Patch will be automatically applied.
Agreed, the patch seems small enough to be included in Buildroot
directly.
That said, I've also found a bit strange that our package
infrastructure enforces that the patches must be located on the same
site, at the same location, as the original tarball. It doesn't make
much sense. So we might want to change that in the future, but for this
specific case, having the patch directly in Buildroot makes sense, I
agree.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-01-18 15:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 21:30 [Buildroot] need help adding apache to buildroot Jenkins, Lee
2013-01-16 21:35 ` Gustavo Zacarias
2013-01-17 22:41 ` Jenkins, Lee
2013-01-18 9:25 ` Jérôme Pouiller
2013-01-18 15:31 ` Thomas Petazzoni [this message]
2013-01-18 16:11 ` [Buildroot] [PATCH] Add support for plain URL in $(PKG)_PATCH variable Jérôme Pouiller
2013-01-30 18:59 ` Yann E. MORIN
2013-01-30 19:23 ` Yann E. MORIN
2013-01-30 22:37 ` Jérôme Pouiller
2013-01-30 22:37 ` Jérôme Pouiller
2013-01-30 22:54 ` Yann E. MORIN
2013-01-30 23:11 ` Jérôme Pouiller
2013-01-31 8:18 ` [Buildroot] [PATCH 1/2] " Jérôme Pouiller
2013-01-31 8:18 ` [Buildroot] [PATCH 2/2] Add $(PKG_NAME) in name of downloaded patches Jérôme Pouiller
2013-04-26 6:18 ` Arnout Vandecappelle
2013-05-13 15:51 ` [Buildroot] [PATCH v2] Add support for plain URL in $(PKG)_PATCH variable Jérôme Pouiller
2013-05-13 20:59 ` Yann E. MORIN
2013-05-14 9:51 ` Markos Chandras
2013-09-07 6:12 ` Peter Korsgaard
2013-04-26 6:00 ` [Buildroot] [PATCH 1/2] " Arnout Vandecappelle
2013-01-31 8:20 ` [Buildroot] [PATCH] " Jérôme Pouiller
2013-01-30 22:50 ` Thomas Petazzoni
2013-01-30 22:57 ` Yann E. MORIN
2013-01-30 23:04 ` Jérôme Pouiller
2013-01-30 23:10 ` Yann E. MORIN
2013-01-16 21:54 ` [Buildroot] need help adding apache to buildroot Thomas Petazzoni
2013-07-07 14:16 ` Stephan Hoffmann
2013-07-18 16:46 ` Jenkins, Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118163104.441c2bfb@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox