Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package: cache-calibrator
Date: Tue, 29 Jan 2013 09:52:06 +0100	[thread overview]
Message-ID: <20130129095206.068ce804@skate> (raw)
In-Reply-To: <1359448315-22100-1-git-send-email-sho@relinux.de>

Dear Stephan Hoffmann,

On Tue, 29 Jan 2013 09:31:55 +0100, Stephan Hoffmann wrote:

> +CACHE_CALIBRATOR_SOURCE = calibrator.c
> +CACHE_CALIBRATOR_SITE = http://homepages.cwi.nl/~manegold/Calibrator/src
> +CACHE_CALIBRATOR_EXTRACT_CMDS = cp $(DL_DIR)/$(CACHE_CALIBRATOR_SOURCE) $(D)

I'd prefer to see this below, right before the BUILD_CMDS, as follows:

define CACHE_CALIBRATOR_EXTRACT_CMDS
	cp $(DL_DIR)/$(CACHE_CALIBRATOR_SOURCE) $(@D)
endef

Even though it doesn't change anything, we generally try to use:

VARIABLE = value

for things that are just "values". And:

define VARIABLE_CMDS
	...
endef

for variables that contain commands.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-01-29  8:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29  8:31 [Buildroot] [PATCH] New package: cache-calibrator Stephan Hoffmann
2013-01-29  8:52 ` Thomas Petazzoni [this message]
2013-01-29  9:07 ` Peter Korsgaard
2013-01-29  9:15 ` Stephan Hoffmann
2013-01-29  9:21   ` Stephan Hoffmann
2013-01-29  9:25     ` Peter Korsgaard
2013-01-29  9:36     ` Thomas Petazzoni
2013-01-29  9:53 ` [Buildroot] [PATCH v3] " Stephan Hoffmann
2013-01-29 17:47   ` Arnout Vandecappelle
2013-01-29 20:33   ` Peter Korsgaard
2013-01-30  7:51     ` Stephan Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2013-01-28 16:49 [Buildroot] [PATCH] " Stephan Hoffmann
2013-01-28 18:07 ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130129095206.068ce804@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox