Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] boost: bump version to 1.53.0
Date: Wed, 6 Feb 2013 12:41:48 +0100	[thread overview]
Message-ID: <20130206124148.473db2e1@skate> (raw)
In-Reply-To: <CAP+5e18W7+M-bmRNJLaXhj2XdMAhnVgQgyvVUHMNk-3FOp-DGw@mail.gmail.com>

Dear Victor Hiairrassary,

Would it be possible to use an e-mail client that complies with the
open-source community standards, by sending e-mails as plain text? The
plain text version of your e-mail makes no discussion between what you
said and what I said, which is very confusing.

On Wed, 6 Feb 2013 12:15:43 +0100, Victor Hiairrassary wrote:

>  Maybe there was a reason why "context" was unconditionally excluded
> from the build, before your patch. Did you check why?
> 
>  context was excluded because compilation is impossible with boost
> 1.52.0 and uClibc, there is a problem with uintptr_t and intptr_t.
> But this is fixed in latest version, 1.53.0.

Ok. This should be mentioned in the commit log, then.

> Also, it would be good to have a comment here that explains why python
> and atomic are unconditionally excluded for the build.
> 
>  atomic is a new boost library since boost 1.53.0. It is excluded because
> it can not compile with uClibc (uintptr_t missing too), but this is now
> fixed in
> trunk version, see ticket https://svn.boost.org/trac/boost/ticket/7979

Ok. This should be mentioned in a comment above the line that disables
the atomic module, so that we know in the future why it is disabled.

> In this patch, atomic is simply excluded. So either we wait for boost 1.54.0
> releasing orI can add the patch to fix atomic compilation in buildroot and
> add boost-atomic in menuconfig?

No, it's perfectly fine to have the atomic thing disabled for now,
since it wasn't available in Buildroot until now. I just want a comment
explaining why it's disabled.

> I do not nothing about pyhton exclusion, sorry.

Ok. But since you're not changing this, it's not necessarily your
responsibility to justify this, so we can leave this part as is.

Could you resubmit a new version of the patch, with more details in the
commit log, and a comment before the line disabling the atomic module?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-02-06 11:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06  9:30 [Buildroot] [PATCH] boost: bump version to 1.53.0 victor.hiairrassary.ml at gmail.com
2013-02-06  9:30 ` victor.hiairrassary.ml at gmail.com
2013-02-06  9:32   ` Thomas Petazzoni
2013-02-06 11:15     ` Victor Hiairrassary
2013-02-06 11:41       ` Thomas Petazzoni [this message]
2013-02-06 16:27         ` Victor Hiairrassary
2013-02-07 15:42         ` Victor Hiairrassary
2013-02-07 19:04           ` Baruch Siach
     [not found] <[PATCH] boost: bump version to 1.53.0>
2013-02-06 16:27 ` victor.hiairrassary.ml at gmail.com
2013-04-14 19:24   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130206124148.473db2e1@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox