From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-infra: start using <pkg>_CONFIG_FIXUP, part 1
Date: Thu, 7 Feb 2013 15:45:52 +0100 [thread overview]
Message-ID: <20130207154552.5deb6670@skate> (raw)
In-Reply-To: <CAHXCMMK5FQ7mbgtWd9FZR_q_5MwZCtQR=_KXsPPX73EhGue=jg@mail.gmail.com>
Dear Samuel Martin,
On Thu, 7 Feb 2013 14:44:43 +0100, Samuel Martin wrote:
> 2013/2/6 Stefan Fr?berg <stefan.froberg@petroprogram.com>:
> > This patch will update those package *.mk files that are already
> > using some per-package fix of *-config files to use more generic
> > <pkg>_CONFIG_FIXUP variable making *.mk files more smaller,
> > neater and easier to eyes.
> >
> > Signed-off-by: Stefan Fr?berg <stefan.froberg@petroprogram.com>
> > ---
> > This package list was taked directly from Samuel Martins post
> > http://lists.busybox.net/pipermail/buildroot/2013-January/065814.html
FWIW, I've sent patches that supersedes this one:
http://patchwork.ozlabs.org/patch/218799/
http://patchwork.ozlabs.org/patch/218797/
They are slightly different than Stefan's one:
* They clearly separate the packages that can directly be changed
to <pkg>_CONFIG_SCRIPTS without thinking, because the fixup done by
the infrastructure is exactly the same as the one that was done by
the package (first patch mentioned above), from the packages that
need a little bit more thought because the fixup is different
(second patch mentioned above).
* They take into account the fact that my patch series slightly
improves <pkg>_CONFIG_SCRIPTS compared to what Stefan did: in my
proposal, <pkg>_CONFIG_SCRIPTS also automatically removes the
<foo>-config script from $(TARGET_DIR)/usr/bin automatically, so a
number of POST_INSTALL_TARGET_HOOKS in packages have become
useless and are removed by my patches.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2013-02-07 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 13:05 [Buildroot] [PATCH] pkg-infra: start using <pkg>_CONFIG_FIXUP, part 1 Stefan Fröberg
2013-02-07 13:44 ` Samuel Martin
2013-02-07 14:45 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207154552.5deb6670@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox