From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5: add rPi EGL glue code
Date: Fri, 1 Mar 2013 17:57:26 +0100 [thread overview]
Message-ID: <20130301175726.1bf80e2e@skate> (raw)
In-Reply-To: <1362156380-27083-1-git-send-email-bos@je-eigen-domein.nl>
Dear Floris Bos,
On Fri, 1 Mar 2013 17:46:20 +0100, Floris Bos wrote:
> When the rpi-userland package is selected, assume we are targetting the Raspberry Pi, and add the right
> platform glue code when building the Qt5 EGLFS plugin.
>
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
Sounds great. Could you wrap your commit log to ~80 columns? I'd like
to apply your patch as-is in my patch series in order to preserve your
authorship.
> +QT5BASE_CONFIGURE_OPTS += -I$(STAGING_DIR)/usr/include/interface/vcos/pthreads
> +QT5BASE_CONFIGURE_OPTS += -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux
Are you sure this is needed? I've added the installation of some .pc
files in the rpi-userland package. At least the first header path is
part of the .pc file for libEGL.
++Cflags: -I${includedir}/ -I${includedir}/interface/vcos/pthreads/
We can of course add the second one as well, as long as we understand
if it's needed for OpenGL or EGL.
See the patch 07/30 in my series.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-01 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 16:46 [Buildroot] [PATCH] qt5: add rPi EGL glue code Floris Bos
2013-03-01 16:57 ` Thomas Petazzoni [this message]
2013-03-01 22:12 ` Floris Bos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301175726.1bf80e2e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox