Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/6] fs/ext2: add ability to build ext3/4 too
Date: Sun, 10 Mar 2013 14:58:51 +0100	[thread overview]
Message-ID: <20130310145851.4f1f6539@skate> (raw)
In-Reply-To: <b55a35d2b1dc1f5bb2598cc8bb29f787407250bc.1362693453.git.yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Thu,  7 Mar 2013 23:04:39 +0100, Yann E. MORIN wrote:

> +    # e2fsck will force a UUID, which we do not want
> +    tune2fs -U clear "${IMG}"

I think you already explained that you're removing the UUID to make the
filesystem creation reproducible (i.e avoid having random bits in the
filesystem image). Even though I'm not it's entirely feasible (some
binaries inside the filesystem may contain build dates and things like
that), I think it's an interesting goal. So my only suggestion here
would be to extend a bit your comment, to explain *why* you do not want
this UUID.

Maybe we could set the volume name to 'buildroot' ? I.e:

	tune2fs -L buildroot "${IMG}"

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-03-10 13:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 22:04 [Buildroot] [pull request v2] Pull request for branch yem-ext234 Yann E. MORIN
2013-03-07 22:04 ` [Buildroot] [PATCH 1/6] fs/ext2: enclose the ext2 options in if...endif Yann E. MORIN
2013-03-10 13:41   ` Thomas Petazzoni
2013-03-07 22:04 ` [Buildroot] [PATCH 2/6] fs/ext2: add ability to build ext3/4 too Yann E. MORIN
2013-03-10 13:52   ` Thomas Petazzoni
2013-03-11  0:20     ` Yann E. MORIN
2013-03-11 21:21       ` Thomas Petazzoni
2013-03-10 13:58   ` Thomas Petazzoni [this message]
2013-03-11  0:26     ` Yann E. MORIN
2013-03-12 17:40     ` Arnout Vandecappelle
2013-03-12 22:56       ` Yann E. MORIN
2013-03-07 22:04 ` [Buildroot] [PATCH 3/6] fs: allow image generators to specify file-extension Yann E. MORIN
2013-03-07 22:04 ` [Buildroot] [PATCH 4/6] fs/ext2: use the ext2 variant to name the generated rootfs image Yann E. MORIN
2013-03-10 13:55   ` Thomas Petazzoni
2013-03-12 17:42     ` Arnout Vandecappelle
2013-03-12 22:51     ` Yann E. MORIN
2013-03-14  7:22       ` Arnout Vandecappelle
2013-03-14 18:16         ` Yann E. MORIN
2013-03-07 22:04 ` [Buildroot] [PATCH 5/6] fs/ext2: add support for ext2 rev0 and rev1 Yann E. MORIN
2013-03-12 17:44   ` Arnout Vandecappelle
2013-03-07 22:04 ` [Buildroot] [PATCH 6/6] fs/ext2: remove count- and time-based fsck Yann E. MORIN
2013-03-12 17:46   ` Arnout Vandecappelle
2013-03-10 13:31 ` [Buildroot] [pull request v2] Pull request for branch yem-ext234 Thomas Petazzoni
2013-03-11  0:05   ` Yann E. MORIN
2013-03-17 22:20   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130310145851.4f1f6539@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox