From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC/PATCH] fs/common.mk: Fix wrong double dollar usage
Date: Tue, 12 Mar 2013 05:30:01 -0300 [thread overview]
Message-ID: <20130312083000.GA2506@localhost> (raw)
In-Reply-To: <1362863052-8781-1-git-send-email-ezequiel.garcia@free-electrons.com>
On Sat, Mar 09, 2013 at 06:04:12PM -0300, Ezequiel Garcia wrote:
> Double dollar sign is used to put an explicit dollar sign,
> for instance, when writing a makefile rule.
>
> In this case, there are some makefile conditionals where
> makefile variables are evaluated using double dollar signs
> instead of single dollar, which is wrong.
>
> In particular, this fixes a buildroot 'make' stall
> when building with an empty device table (empty BR2_ROOTFS_DEVICE_TABLE).
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> I'm sending this as RFC because I'm new to buildroot
> and because I'm not a makefile wizard.
> AFAIK, this fixes a real bug in my compilation,
> as explained in the commit message.
>
> fs/common.mk | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
Any comments? How does this look like?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-03-12 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 21:04 [Buildroot] [RFC/PATCH] fs/common.mk: Fix wrong double dollar usage Ezequiel Garcia
2013-03-12 8:30 ` Ezequiel Garcia [this message]
2013-03-12 9:05 ` Thomas De Schampheleire
2013-03-12 10:06 ` Ezequiel Garcia
2013-03-12 11:28 ` Thomas De Schampheleire
2013-03-12 12:44 ` Ezequiel Garcia
2013-03-12 13:34 ` Thomas De Schampheleire
2013-03-12 22:22 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312083000.GA2506@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox