From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] python-thrift: new package
Date: Wed, 13 Mar 2013 08:30:19 +0100 [thread overview]
Message-ID: <20130313083019.4d9129ff@skate> (raw)
In-Reply-To: <1363115372-5679-1-git-send-email-viniciustinti@gmail.com>
Dear Vinicius Tinti,
On Tue, 12 Mar 2013 16:09:31 -0300, Vinicius Tinti wrote:
> diff --git a/package/python-thrift/Config.in b/package/python-thrift/Config.in
> new file mode 100644
> index 0000000..3aa6bfb
> --- /dev/null
> +++ b/package/python-thrift/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PYTHON_THRIFT
> + bool "python-thrift"
> + depends on BR2_PACKAGE_PYTHON
The "depends on BR2_PACKAGE_PYTHON" here is not needed, since the
'source "package/python-thrift/Config.in"' in package/Config.in is
already enclosed in a if BR2_PACKAGE_PYTHON...endif.
> +PYTHON_THRIFT_VERSION = 0.9.0
> +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz
> +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/
Could you add PYTHON_THRIFT_LICENSE and PYTHON_THRIFT_LICENSE_FILES ?
Otherwise, looks good to me.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-13 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 19:09 [Buildroot] [PATCH 1/1] python-thrift: new package Vinicius Tinti
2013-03-13 7:30 ` Thomas Petazzoni [this message]
2013-03-13 11:06 ` Tinti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313083019.4d9129ff@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox