Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3] Added package HPLIP for printing to HP printers
Date: Fri, 15 Mar 2013 10:47:04 +0100	[thread overview]
Message-ID: <20130315104704.1c268db3@skate> (raw)
In-Reply-To: <1363203368-19909-1-git-send-email-olivier.schonken@gmail.com>

Dear Olivier Schonken,

On Wed, 13 Mar 2013 21:36:08 +0200, Olivier Schonken wrote:
> HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution
> for printing, scanning, and faxing with HP inkjet and laser based printers
> in Linux.
> 
> The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even
> with the modified Makefile.am for a succesful build.
> 
> Created a menu for cups related components to be kept close together.
> 
> Fixed a jpeg and dbus dependencies, Thanks for pointing out the dbus 
> dependency Baruch.

The "changelog" shouldn't go in the commit log, but instead...

> 
> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
> ---

... here. Otherwise, it gets committed and kept in the project history,
which doesn't make much sense.

> new file mode 100644
> index 0000000..1bfac40
> --- /dev/null
> +++ b/package/hplip/hplip.mk
> @@ -0,0 +1,52 @@
> +#############################################################
> +#
> +# hplip
> +#
> +#############################################################
> +
> +HPLIP_VERSION = 3.12.11
> +HPLIP_SITE = http://downloads.sourceforge.net/hplip/hplip/
> +HPLIP_AUTORECONF = YES
> +HPLIP_DEPENDENCIES = cups libusb jpeg

You should add HPLIP_LICENSE and HPLIP_LICENSE_FILES here.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-03-15  9:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-02 17:02 [Buildroot] [PATCH 1/1] Added package HPLIP for printing to HP printers Olivier Schonken
2013-03-03 18:07 ` Thomas Petazzoni
2013-03-03 21:26   ` [Buildroot] [PATCHv2] " Olivier Schonken
2013-03-04  8:41     ` Baruch Siach
2013-03-13 19:36       ` [Buildroot] [PATCHv3] " Olivier Schonken
2013-03-15  9:47         ` Thomas Petazzoni [this message]
2013-03-15 18:27 ` [Buildroot] [PATCHv4] " Olivier Schonken
2013-03-18 20:19   ` Peter Korsgaard
2013-03-19  6:55 ` [Buildroot] [PATCHv5] " Olivier Schonken
2013-03-19 12:08   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130315104704.1c268db3@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox