From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] zeromq: add C++ bindings
Date: Mon, 18 Mar 2013 17:06:14 +0100 [thread overview]
Message-ID: <20130318170614.2c9d21f3@skate> (raw)
In-Reply-To: <1363618617-2969-1-git-send-email-spdawson@gmail.com>
Simon,
On Mon, 18 Mar 2013 14:56:57 +0000, spdawson at gmail.com wrote:
> diff --git a/package/Config.in b/package/Config.in
> index 9853b06..9519852 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -495,6 +495,7 @@ source "package/mediastreamer/Config.in"
> endmenu
>
> menu "Networking"
> +source "package/cppzmq/Config.in"
> source "package/glib-networking/Config.in"
> source "package/libcgi/Config.in"
> source "package/libcgicc/Config.in"
> @@ -535,6 +536,7 @@ source "package/ortp/Config.in"
> source "package/slirp/Config.in"
> source "package/usbredir/Config.in"
> source "package/zeromq/Config.in"
> +source "package/zmqpp/Config.in"
> endmenu
You should probably submit two separate patches for the two separate
packages.
> menu "Other"
> diff --git a/package/cppzmq/Config.in b/package/cppzmq/Config.in
> new file mode 100644
> index 0000000..6ec168e
> --- /dev/null
> +++ b/package/cppzmq/Config.in
> @@ -0,0 +1,2 @@
> +config BR2_PACKAGE_CPPZMQ
> + bool
Why don't you make this a normal package?
> +CPPZMQ_INSTALL_TARGET = NO
Not needed.
> +config BR2_PACKAGE_ZEROMQ_CPP
> + bool "C++ bindings"
> + depends on BR2_PACKAGE_ZEROMQ
> + depends on BR2_INSTALL_LIBSTDCPP
> + select BR2_PACKAGE_CPPZMQ
> + select BR2_PACKAGE_ZMQPP
> + help
> + C++ bindings.
I really believe cppzmq and zmqpp should be normal separate packages,
that select the zeromq package. I don't see why we would "invert" the
traditional logic we use for all packages.
> new file mode 100644
> index 0000000..954cf29
> --- /dev/null
> +++ b/package/zmqpp/Config.in
> @@ -0,0 +1,2 @@
> +config BR2_PACKAGE_ZMQPP
> + bool
Same thing for zmqpp.
> +define ZMQPP_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(ZMQPP_MAKE_ENV) $(MAKE) $(ZMQPP_MAKE_OPT) -C $(@D)
> +endef
I'm surprised, you're not passing CC, CXX and al. ? Not needed?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-18 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 14:56 [Buildroot] [PATCH] zeromq: add C++ bindings spdawson at gmail.com
2013-03-18 15:27 ` Baruch Siach
2013-03-18 16:39 ` Simon Dawson
2013-03-18 16:06 ` Thomas Petazzoni [this message]
2013-03-18 16:41 ` Simon Dawson
2013-03-19 5:42 ` Alexander Lukichev
2013-03-19 7:27 ` Simon Dawson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130318170614.2c9d21f3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox