From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Added package enscript
Date: Mon, 18 Mar 2013 17:34:41 +0100 [thread overview]
Message-ID: <20130318173441.0e7fe442@skate> (raw)
In-Reply-To: <1363535972-29959-1-git-send-email-olivier.schonken@gmail.com>
Dear Olivier Schonken,
On Sun, 17 Mar 2013 17:59:31 +0200, Olivier Schonken wrote:
> menu "Interpreter languages and scripting"
> source "package/erlang/Config.in"
> +source "package/enscript/Config.in"
> source "package/haserl/Config.in"
> source "package/jamvm/Config.in"
> source "package/lua/Config.in"
Even though strictly speaking, enscript is an interpreter, I don't
think I would put it under the "Interpreter languages and scripting"
section.
> +config BR2_PACKAGE_ENSCRIPT
> + bool "enscript"
> + select BR2_PACKAGE_GETTEXT
Why? You don't even have gettext as a dependency in the .mk file.
Moreover, gettext handling is generally more complicated than just a
simple select, see
http://buildroot.org/downloads/manual/manual.html#_gettext_integration_and_interaction_with_packages.
> diff --git a/package/enscript/enscript.mk b/package/enscript/enscript.mk
> new file mode 100644
> index 0000000..29fd6d4
> --- /dev/null
> +++ b/package/enscript/enscript.mk
> @@ -0,0 +1,20 @@
> +#############################################################
> +#
> +# enscript
> +#
> +#############################################################
> +ENSCRIPT_VERSION = 1.6.6
Nitpick: one empty line between header and first variable.
> +ENSCRIPT_SITE = $(BR2_GNU_MIRROR)/enscript/
> +ENSCRIPT_SOURCE = enscript-$(ENSCRIPT_VERSION).tar.gz
Line not needed.
> +ENSCRIPT_DEPENDENCIES =
Line not needed.
> +ENSCRIPT_LICENSE = GPLv3
The license is really not GPLv3+ ?
> +ENSCRIPT_LICENSE_FILES = COPYING
> +
> +#Enable pthread threads if toolchain supports threads
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS), y)
No space before the "y".
> + ENSCRIPT_CONF_OPT += --enable-threads=pth
> +else
> + ENSCRIPT_CONF_OPT += --disable-threads
> +endif
> +
> +$(eval $(autotools-package))
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2013-03-18 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 15:59 [Buildroot] [PATCH 1/2] Added package enscript Olivier Schonken
2013-03-17 15:59 ` [Buildroot] [PATCH 2/2] Added package foomatic-filters Olivier Schonken
2013-03-17 20:04 ` [Buildroot] [PATCH 1/2] Added package enscript Olivier Schonken
2013-03-18 16:34 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130318173441.0e7fe442@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox