From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] rework patch model
Date: Tue, 19 Mar 2013 20:56:55 +0100 [thread overview]
Message-ID: <20130319205655.0e163354@skate> (raw)
In-Reply-To: <1363598027-25900-1-git-send-email-spdawson@gmail.com>
Simon,
On Mon, 18 Mar 2013 09:13:47 +0000, spdawson at gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> At the Buildroot Developers Meeting (4-5 February 2013, in Brussels) a change
> to the patch logic was discussed. See
>
> http://elinux.org/Buildroot:DeveloperDaysFOSDEM2013
>
> for details. In summary:
>
> * For patches stored in the package directory, if
> package/<pkg>/<version>/ does exist, apply package/<pkg>/<version>/*.patch,
> otherwise, apply package/<pkg>/*.patch
> * For patches stored in the global patches directory, if
> $(GLOBAL_PATCH_DIR)/<pkg>/<version>/ does exist, apply
> $(GLOBAL_PATCH_DIR)/<pkg>/<version>/*.patch, otherwise, apply
> $(GLOBAL_PATCH_DIR)/<pkg>/*.patch
>
> This patch adds the new BR2_GLOBAL_PATCH_DIR configuration item, and reworks
> the generic package infrastructure to implement the new patch logic.
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
One minor nit below, but doesn't prevent from committing the patch IMO.
Peter can probably fix that up when committing.
> +It is sometimes useful to apply 'extra' patches to packages - over and
> +above those provided in Buildroot. This might be used to support custom
> +features in a project, for example, or when working on a new architecture.
> +
> +The +BR2_GLOBAL_PATCH_DIR+ configuration file option can be
> +used to specify a directory containing global package patches.
> +
> +For a specific version <packageversion> of a specific package <packagename>,
> +patches are applied as follows.
> +
> +First, the default Buildroot patch set for the package is applied.
> +
> +If the directory $(BR2_GLOBAL_PATCH_DIR)/<packagename>/<packageversion>
Should be +$(BR2_GLOBAL_PATCH_DIR)/<packagename>/<packageversion>+
> +exists, then all *.patch files in the directory will be applied.
Should be +*.patch+.
So really, it's nitpicking :-)
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-03-19 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 9:13 [Buildroot] [PATCH v3] rework patch model spdawson at gmail.com
2013-03-19 19:56 ` Thomas Petazzoni [this message]
2013-03-19 21:46 ` Samuel Martin
2013-03-19 22:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319205655.0e163354@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox