From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [pull request v5] Pull request for branch for-master/doc
Date: Sat, 23 Mar 2013 18:03:41 +0100 [thread overview]
Message-ID: <20130323180341.238aeeef@skate> (raw)
In-Reply-To: <cover.1363899518.git.s.martin49@gmail.com>
Dear Samuel Martin,
On Thu, 21 Mar 2013 22:04:31 +0100, Samuel Martin wrote:
> The following changes since commit 1f721a2f009393c29c6554f643f15f80a8dc5443:
>
> xinetd: follow the convention for patch location (2013-03-20 23:28:27 +0100)
>
> are available in the git repository at:
>
> git://github.com/tSed/buildroot.git for-master/doc
>
> for you to fetch changes up to 8be5fe492147513305626d9665d4119c548be11e:
>
> manual: update generated lists (2013-03-21 21:33:12 +0100)
I tested the current version of your branch (top commit
a368f70b7cee5ebba4d2cf6f09db08799b685af5), which contains the PATCH 6/6
that replaces the previous 6/7 and 7/7.
For the version of your branch:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
I think there are still a few things that could be improved, but this
series has already been around for some time, and I'd like to see it
committed even though additional improvements may be brought to it.
Amongst the possible improvements:
* Generate the package list files in $(O) in order to avoid having a
compilation process that requires writing to the Buildroot source
tree.
* Don't use the word "stuff" for deprecated features, but instead use
"Deprecated features".
* Add a .gitignore entry to ignore the kconfiglib.pyc file generated
in support/scripts/.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2013-03-23 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 21:04 [Buildroot] [pull request v5] Pull request for branch for-master/doc Samuel Martin
2013-03-21 21:04 ` [Buildroot] [PATCH 1/7] manual: add manual generation date/git revision in the manual text Samuel Martin
2013-03-21 21:04 ` [Buildroot] [PATCH 2/7] support: add kconfiglib python module Samuel Martin
2013-03-21 21:04 ` [Buildroot] [PATCH 3/7] support/scripts: add gen-manual-lists.py Samuel Martin
2013-03-21 21:04 ` [Buildroot] [PATCH 4/7] manual: cleanup appendix.txt Samuel Martin
2013-03-21 21:04 ` [Buildroot] [PATCH 5/7] manual: add a make target 'manual-update-lists' Samuel Martin
2013-03-21 21:04 ` [Buildroot] [PATCH 6/7] Makefile: add to the release target a warning about the manual updates Samuel Martin
2013-03-21 21:04 ` [Buildroot] [PATCH 7/7] manual: update generated lists Samuel Martin
2013-03-22 8:23 ` Thomas Petazzoni
2013-03-23 17:03 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130323180341.238aeeef@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox