Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/7] arch: toolchain: Introduce target CPU revision.
Date: Sun, 7 Apr 2013 22:42:06 +0200	[thread overview]
Message-ID: <20130407224206.5948990b@skate> (raw)
In-Reply-To: <1364550643-11793-2-git-send-email-sonic.adi@gmail.com>

Dear Sonic Zhang,

On Fri, 29 Mar 2013 17:50:38 +0800, Sonic Zhang wrote:

> +config BR2_GCC_TARGET_CPU_REVISION
> +	string "Target CPU revision"
> +	help
> +	  Specify target cpu revision which is passed to compiler as a parameter.

I think this line is slightly too long, it should be wrapped. And I
would like more details here in the help text. Maybe something like:

	Specify a target CPU revision, which will be appended to the
	value of the -mcpu option. For example, if the selected CPU is
	bf607, and then selected CPU revision is "r2", then gcc will
	receive the -mcpu=bf607-r2 option.

Other than this detail, looks good to me.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-04-07 20:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29  9:50 [Buildroot] [PATCH v2 1/7] arch: Add blackfin CPU choice Sonic Zhang
2013-03-29  9:50 ` [Buildroot] [PATCH v2 2/7] arch: toolchain: Introduce target CPU revision Sonic Zhang
2013-04-07 20:42   ` Thomas Petazzoni [this message]
2013-04-08  6:30     ` Sonic Zhang
2013-03-29  9:50 ` [Buildroot] [PATCH v2 3/7] arch: toolchain: Introduce binary formats BINFMT_* Sonic Zhang
2013-04-07 20:45   ` Thomas Petazzoni
2013-04-08  6:03     ` Sonic Zhang
2013-04-07 20:47   ` Thomas Petazzoni
2013-04-08  6:04     ` Sonic Zhang
2013-03-29  9:50 ` [Buildroot] [PATCH v2 4/7] arch: toolchain: Introduce binary format FLAT types Sonic Zhang
2013-04-07 20:51   ` Thomas Petazzoni
2013-04-08  6:43     ` Sonic Zhang
2013-04-12  3:39     ` Sonic Zhang
2013-04-13 14:31       ` Thomas Petazzoni
2013-04-16 10:26         ` Sonic Zhang
2013-04-16 10:46           ` Thomas Petazzoni
2013-04-17  9:02             ` Sonic Zhang
2013-04-23  5:57               ` Sonic Zhang
2013-03-29  9:50 ` [Buildroot] [PATCH v2 5/7] package: Introduce package-specific BINFMT_FLAT options Sonic Zhang
2013-04-07 21:27   ` Thomas Petazzoni
2013-04-10  5:47     ` Arnout Vandecappelle
2013-04-10  8:10       ` Sonic Zhang
2013-04-10 10:36         ` Arnout Vandecappelle
2013-03-29  9:50 ` [Buildroot] [PATCH v2 6/7] arch: Introduce blackfin-specific Makefile Sonic Zhang
2013-04-07 21:41   ` Thomas Petazzoni
2013-04-08  7:19     ` Sonic Zhang
2013-04-08 21:23       ` Thomas Petazzoni
2013-03-29  9:50 ` [Buildroot] [PATCH v2 7/7] package: Introduce NOMMU symbol Sonic Zhang
2013-04-07 20:39 ` [Buildroot] [PATCH v2 1/7] arch: Add blackfin CPU choice Thomas Petazzoni
2013-04-08  3:28   ` Sonic Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130407224206.5948990b@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox